LGTM On Wed, May 12, 2010 at 6:11 PM, <[email protected]> wrote:
> Reviewers: amitmanjhi, > > Description: > Factored out the invoke method for a READ request. > > Patch by: [email protected] > Commited by: amitmanjhi > Review by: amitmanjhi > > > Please review this at http://gwt-code-reviews.appspot.com/519801/show > > Affected files: > M > trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java > > > Index: > trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java > =================================================================== > --- > trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java > (revision 8109) > +++ > trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java > (working copy) > @@ -130,7 +130,7 @@ > Object args[] = RequestDataManager.getObjectsFromParameterMap( > getParameterMap(topLevelJsonObject), > domainMethod.getParameterTypes()); > - Object result = domainMethod.invoke(null, args); > + Object result = invokeStaticDomainMethod(domainMethod, args); > > if ((result instanceof List<?>) != operation.isReturnTypeList()) { > throw new IllegalArgumentException(String.format( > @@ -569,6 +569,11 @@ > return violationsAsJson; > } > > + private Object invokeStaticDomainMethod(Method domainMethod, > + Object args[]) throws IllegalAccessException, > InvocationTargetException { > + return domainMethod.invoke(null, args); > + } > + > /** > * returns true if the property has been requested. TODO: use the > properties > * that should be coming with the request. > > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
