LGTM

http://gwt-code-reviews.appspot.com/516801/diff/1/2
File user/src/com/google/gwt/core/client/impl/Md5Digest.java (right):

http://gwt-code-reviews.appspot.com/516801/diff/1/2#newcode280
user/src/com/google/gwt/core/client/impl/Md5Digest.java:280: //
TODO(jat): do away with long math
May be it would be better to keep the long math. It is slow, but in this
case the alternative is to re-implement the same thing again (perhaps as
an array of two ints like in RFC1321). long nicely abstracts that out.

If performance is a concern, perhaps it would be better to have a JSNI
implementation.

http://gwt-code-reviews.appspot.com/516801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to