Reviewers: amitmanjhi,
Description:
Stop trying to be clever on delete, it breaks things
Review by: [email protected]
Please review this at http://gwt-code-reviews.appspot.com/522801/show
Affected files:
M
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
Index:
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
===================================================================
---
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
(revision 8109)
+++
/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
(working copy)
@@ -36,9 +36,9 @@
* Subclasses must:
*
* <ul>
- * <li>implement a method for creating request objects
+ * <li>implement methods to provide a full count, and request a specific
* <li>provide a {...@link RecordListView}
- * <li>respond to "show" and "edit" requests
+ * <li>respond to "show details" commands
* </ul>
*
* Only the properties required by the view will be requested.
@@ -147,7 +147,7 @@
break;
case DELETE:
- delete(record);
+ init();
break;
case CREATE:
@@ -169,13 +169,6 @@
protected abstract void fireCountRequest(Receiver<Long> callback);
protected abstract void showDetails(R record);
-
- private void delete(R record) {
- Integer row = recordToRow.get(record.getId());
- if (row != null) {
- onRangeChanged(view.asPagingListView());
- }
- }
private void getLastPage() {
fireCountRequest(new Receiver<Long>() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
