Let's see if the build file can be simplified some. The rest looks good.


http://gwt-code-reviews.appspot.com/547801/diff/1/4
File /user/build.xml (right):

http://gwt-code-reviews.appspot.com/547801/diff/1/4#newcode598
/user/build.xml:598: <property name="compile.tests.complete"
value="true"/>
This looks too tricky. Is it here so that the benchmark targets can
depend on various targets, and yet prevent those targets from actually
building?  If so, why not simply depend on more specifically what the
targets require to be built?

If the existing ant targets are too coarse, then they can certainly be
factored into more specific ones.

http://gwt-code-reviews.appspot.com/547801/diff/1/4#newcode608
/user/build.xml:608: -->
I don't see anything running in parallel here. Drop the parallel and
sequential tags and make it simply three antcalls ?

http://gwt-code-reviews.appspot.com/547801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to