LGTM.
http://gwt-code-reviews.appspot.com/335802/diff/1/4 File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java (left): http://gwt-code-reviews.appspot.com/335802/diff/1/4#oldcode221 user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:221: interface HasRect { On 2010/04/16 18:24:03, bobv wrote:
Removed this interface because it is silly.
Always a good reason :) http://gwt-code-reviews.appspot.com/335802/diff/1/6 File user/test/com/google/gwt/resources/client/ImageResourceTest.java (right): http://gwt-code-reviews.appspot.com/335802/diff/1/6#newcode167 user/test/com/google/gwt/resources/client/ImageResourceTest.java:167: assertEquals(128, r.scaledUp().getHeight()); I assume the point of testing both width and height here (even though only width is set above) is to assert that the image scaled proportionally, right? http://gwt-code-reviews.appspot.com/335802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
