LGTM if the extra comments are removed and the JRE compatibility
question is checked.


http://gwt-code-reviews.appspot.com/602801/diff/1/2
File user/super/com/google/gwt/emul/java/lang/Math.java (right):

http://gwt-code-reviews.appspot.com/602801/diff/1/2#newcode30
user/super/com/google/gwt/emul/java/lang/Math.java:30: //    return (x
<= 0.0) ? 0.0 - x : x;
Why are these comments being added?

http://gwt-code-reviews.appspot.com/602801/diff/1/2#newcode258
user/super/com/google/gwt/emul/java/lang/Math.java:258: return
(Math.exp(x) - Math.exp(-x)) / 2.0;
On these, do we need to do anything special with NaNs/infinity to get
JRE-compatible behavior?

http://gwt-code-reviews.appspot.com/602801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to