LGTM

http://gwt-code-reviews.appspot.com/607801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLibBase.java (right):

http://gwt-code-reviews.appspot.com/607801/diff/1/2#newcode412
dev/core/super/com/google/gwt/lang/LongLibBase.java:412: private static
int numberOfLeadingZeros(LongEmul a) {
Where is this tested?

http://gwt-code-reviews.appspot.com/607801/diff/1/3
File dev/core/test/com/google/gwt/lang/LongLibTest.java (right):

http://gwt-code-reviews.appspot.com/607801/diff/1/3#newcode18
dev/core/test/com/google/gwt/lang/LongLibTest.java:18: public abstract
long ref(long l0, long l1);
I really hate single-letter l variables, even with digits, because
depending on the font it can be very hard to distinguish from the digit
1.  How about v or val instead of l everywhere here?

http://gwt-code-reviews.appspot.com/607801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to