[gwt-contrib] [google-web-toolkit] r8243 committed - Fix implementation of Math.sinh and Math.tanh (external issue 4991)...

[codesite-noreply]

Revision: 8243
Author: r...@google.com
Date: Mon Jun 14 04:54:34 2010
Log: Fix implementation of Math.sinh and Math.tanh (external issue 4991)
Review at http://gwt-code-reviews.appspot.com/602801

Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8243

Modified:
 /trunk/user/super/com/google/gwt/emul/java/lang/Math.java
 /trunk/user/test/com/google/gwt/emultest/java/lang/MathTest.java

=======================================
--- /trunk/user/super/com/google/gwt/emul/java/lang/Math.java	Fri May 28  
10:04:54 2010
+++ /trunk/user/super/com/google/gwt/emul/java/lang/Math.java	Mon Jun 14  
04:54:34 2010
@@ -27,11 +27,11 @@
   private static final double PI_UNDER_180 = 180.0 / PI;

   public static double abs(double x) {
-    return x < 0 ? -x : x;
+    return (x <= 0.0) ? 0.0 - x : x;
   }

   public static float abs(float x) {
-    return x < 0 ? -x : x;
+    return (x <= 0.0F) ? 0.0F - x : x;
   }

   public static int abs(int x) {
@@ -253,7 +253,7 @@
   }-*/;

   public static native double sinh(double x) /*-{
-    return Math.sinh(x);
+    return (Math.exp(x) - Math.exp(-x)) / 2.0;
   }-*/;

   public static native double sqrt(double x) /*-{
@@ -265,7 +265,11 @@
   }-*/;

   public static native double tanh(double x) /*-{
-    return Math.tanh(x);
+    if (x == Infinity) {
+      return 1.0;
+    }
+    var e2x = Math.exp(2.0 * x);
+    return (e2x - 1) / (e2x + 1);
   }-*/;

   public static double toDegrees(double x) {
=======================================
--- /trunk/user/test/com/google/gwt/emultest/java/lang/MathTest.java	Mon  
Feb 22 13:53:24 2010
+++ /trunk/user/test/com/google/gwt/emultest/java/lang/MathTest.java	Mon  
Jun 14 04:54:34 2010
@@ -29,6 +29,23 @@
   public String getModuleName() {
     return "com.google.gwt.emultest.EmulSuite";
   }
+
+  public void testAbs() {
+    double v = Math.abs(-1.0);
+    assertEquals(1.0, v);
+    v = Math.abs(1.0);
+    assertEquals(1.0, v);
+    v = Math.abs(-0.0);
+    assertEquals(0.0, v);
+    v = Math.abs(0.0);
+    assertEquals(0.0, v);
+    v = Math.abs(Double.NEGATIVE_INFINITY);
+    assertEquals(Double.POSITIVE_INFINITY, v);
+    v = Math.abs(Double.POSITIVE_INFINITY);
+    assertEquals(Double.POSITIVE_INFINITY, v);
+    v = Math.abs(Double.NaN);
+    assertTrue(Double.isNaN(v));
+  }

   public void testCbrt() {
     double v = Math.cbrt(1000.0);
@@ -37,6 +54,8 @@

   public void testCos() {
     double v = Math.cos(0.0);
+    assertEquals(1.0, v, 1e-7);
+    v = Math.cos(-0.0);
     assertEquals(1.0, v, 1e-7);
     v = Math.cos(Math.PI * .5);
     assertEquals(0.0, v, 1e-7);
@@ -44,6 +63,27 @@
     assertEquals(-1.0, v, 1e-7);
     v = Math.cos(Math.PI * 1.5);
     assertEquals(0.0, v, 1e-7);
+    v = Math.cos(Double.NaN);
+    assertTrue(Double.isNaN(v));
+    v = Math.cos(Double.NEGATIVE_INFINITY);
+    assertTrue(Double.isNaN(v));
+    v = Math.cos(Double.POSITIVE_INFINITY);
+    assertTrue(Double.isNaN(v));
+  }
+
+  public void testCosh() {
+    double v = Math.cosh(0.0);
+    assertEquals(1.0, v, 1e-7);
+    v = Math.cosh(1.0);
+    assertEquals(1.5430806348, v, 1e-7);
+    v = Math.cosh(-1.0);
+    assertEquals(1.5430806348, v, 1e-7);
+    v = Math.cosh(Double.NaN);
+    assertTrue(Double.isNaN(v));
+    v = Math.cosh(Double.NEGATIVE_INFINITY);
+    assertEquals(Double.POSITIVE_INFINITY, v);
+    v = Math.cosh(Double.POSITIVE_INFINITY);
+    assertEquals(Double.POSITIVE_INFINITY, v);
   }

   public void testLog() {
@@ -59,11 +99,66 @@
   public void testSin() {
     double v = Math.sin(0.0);
     assertEquals(0.0, v, 1e-7);
+    v = Math.sin(-0.0);
+    assertEquals(-0.0, v, 1e-7);
     v = Math.sin(Math.PI * .5);
     assertEquals(1.0, v, 1e-7);
     v = Math.sin(Math.PI);
     assertEquals(0.0, v, 1e-7);
     v = Math.sin(Math.PI * 1.5);
     assertEquals(-1.0, v, 1e-7);
+    v = Math.sin(Double.NaN);
+    assertTrue(Double.isNaN(v));
+    v = Math.sin(Double.NEGATIVE_INFINITY);
+    assertTrue(Double.isNaN(v));
+    v = Math.sin(Double.POSITIVE_INFINITY);
+    assertTrue(Double.isNaN(v));
+  }
+
+  public void testSinh() {
+    double v = Math.sinh(0.0);
+    assertEquals(0.0, v);
+    v = Math.sinh(1.0);
+    assertEquals(1.175201193, v, 1e-7);
+    v = Math.sinh(-1.0);
+    assertEquals(-1.175201193, v, 1e-7);
+    v = Math.sinh(Double.NaN);
+    assertTrue(Double.isNaN(v));
+    v = Math.sinh(Double.NEGATIVE_INFINITY);
+    assertEquals(Double.NEGATIVE_INFINITY, v);
+    v = Math.sinh(Double.POSITIVE_INFINITY);
+    assertEquals(Double.POSITIVE_INFINITY, v);
+    v = Math.sinh(-0.0);
+    assertEquals(-0.0, v);
+  }
+
+  public void testTan() {
+    double v = Math.tan(0.0);
+    assertEquals(0.0, v, 1e-7);
+    v = Math.tan(-0.0);
+    assertEquals(-0.0, v, 1e-7);
+    v = Math.tan(Double.NaN);
+    assertTrue(Double.isNaN(v));
+    v = Math.tan(Double.NEGATIVE_INFINITY);
+    assertTrue(Double.isNaN(v));
+    v = Math.tan(Double.POSITIVE_INFINITY);
+    assertTrue(Double.isNaN(v));
+  }
+
+  public void testTanh() {
+    double v = Math.tanh(0.0);
+    assertEquals(0.0, v);
+    v = Math.tanh(1.0);
+    assertEquals(0.761594155, v, 1e-7);
+    v = Math.tanh(-1.0);
+    assertEquals(-0.761594155, v, 1e-7);
+    v = Math.tanh(Double.NaN);
+    assertTrue(Double.isNaN(v));
+    v = Math.tanh(Double.NEGATIVE_INFINITY);
+    assertEquals(-1.0, v, 1e-7);
+    v = Math.tanh(Double.POSITIVE_INFINITY);
+    assertEquals(1.0, v, 1e-7);
+    v = Math.tanh(-0.0);
+    assertEquals(-0.0, v);
   }
 }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors