[gwt-contrib] Adds more logging to JUnitShell. The redundant logging will be removed later. (issue611802)

[amitmanjhi]

Reviewers: scottb, jat,

Description:
Adds more logging to JUnitShell. The redundant logging will be removed
later.
Patch by: amitmanjhi
Review by: scottb, jat


Please review this at http://gwt-code-reviews.appspot.com/611802/show

Affected files:
  M dev/core/src/com/google/gwt/dev/DevMode.java
  M dev/core/src/com/google/gwt/dev/DevModeBase.java


Index: dev/core/src/com/google/gwt/dev/DevMode.java
===================================================================
--- dev/core/src/com/google/gwt/dev/DevMode.java        (revision 8282)
+++ dev/core/src/com/google/gwt/dev/DevMode.java        (working copy)
@@ -405,6 +405,7 @@
       String sclArgs = options.getServletContainerLauncherArgs();
       if (sclArgs != null) {
         if (!scl.processArguments(serverLogger, sclArgs)) {
+          serverLogger.log(TreeLogger.ERROR, "Unable to process SCL  
args "  + sclArgs);
           return -1;
         }
       }
Index: dev/core/src/com/google/gwt/dev/DevModeBase.java
===================================================================
--- dev/core/src/com/google/gwt/dev/DevModeBase.java    (revision 8282)
+++ dev/core/src/com/google/gwt/dev/DevModeBase.java    (working copy)
@@ -1047,12 +1047,23 @@
     started = true;

     if (!doStartup()) {
+      /*
+       * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+       * failure. Remove soon.
+       */
+      getTopLogger().log(TreeLogger.ERROR, "shell failed in doStartup  
method");
       return false;
     }

     if (!options.isNoServer()) {
       int resultPort = doStartUpServer();
       if (resultPort < 0) {
+        /*
+         * TODO (amitmanjhi): Adding this redundant logging to narrow down  
a
+         * failure. Remove soon.
+         */
+        getTopLogger().log(TreeLogger.ERROR,
+            "shell failed in doStartupServer method");
         return false;
       }
       options.setPort(resultPort);
@@ -1074,6 +1085,12 @@
     setStartupUrls(getTopLogger());

     if (!doSlowStartup()) {
+      /*
+       * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+       * failure. Remove soon.
+       */
+      getTopLogger().log(TreeLogger.ERROR,
+          "shell failed in doSlowStartup method");
       return false;
     }



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors