Revision: 8283
Author: [email protected]
Date: Fri Jun 18 12:28:31 2010
Log: Adds more logging to JUnitShell. The redundant logging will be removed later.

Patch by: amitmanjhi
Review by: scottb, jat

http://code.google.com/p/google-web-toolkit/source/detail?r=8283

Modified:
 /trunk/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java
 /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java

=======================================
--- /trunk/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java Fri Jan 22 10:18:29 2010 +++ /trunk/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java Fri Jun 18 12:28:31 2010
@@ -70,6 +70,7 @@
    * @return true if the arguments were processed successfully
    */
   public boolean processArguments(TreeLogger logger, String arguments) {
+ logger.log(TreeLogger.ERROR, getName() + " does not accept any arguments");
     return false;
   }

=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Fri May 28 08:44:36 2010 +++ /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Fri Jun 18 12:28:31 2010
@@ -1047,12 +1047,23 @@
     started = true;

     if (!doStartup()) {
+      /*
+       * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+       * failure. Remove soon.
+       */
+ getTopLogger().log(TreeLogger.ERROR, "shell failed in doStartup method");
       return false;
     }

     if (!options.isNoServer()) {
       int resultPort = doStartUpServer();
       if (resultPort < 0) {
+        /*
+ * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+         * failure. Remove soon.
+         */
+        getTopLogger().log(TreeLogger.ERROR,
+            "shell failed in doStartupServer method");
         return false;
       }
       options.setPort(resultPort);
@@ -1074,6 +1085,12 @@
     setStartupUrls(getTopLogger());

     if (!doSlowStartup()) {
+      /*
+       * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+       * failure. Remove soon.
+       */
+      getTopLogger().log(TreeLogger.ERROR,
+          "shell failed in doSlowStartup method");
       return false;
     }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to