Some javadoc somewhere need to be updated with a "Use in UiBinder Templates" section that covers this, see UIObject for an example.
Where exactly to do that is a bit unclear, especially with the recent addition of ValueBoxBase. Any thoughts? http://gwt-code-reviews.appspot.com/612803/diff/1/3 File user/src/com/google/gwt/uibinder/attributeparsers/AttributeParsers.java (right): http://gwt-code-reviews.appspot.com/612803/diff/1/3#newcode37 user/src/com/google/gwt/uibinder/attributeparsers/AttributeParsers.java:37: + "TextAlignConstant"; Could you make these constants use the actual classes? E.g. private static final String HORIZ_CONSTANT = HorizontalAlignmentConstant.class.getName(); http://gwt-code-reviews.appspot.com/612803/diff/1/3#newcode42 user/src/com/google/gwt/uibinder/attributeparsers/AttributeParsers.java:42: private static final String UNIT = "com.google.gwt.dom.client.Style.Unit"; ditto http://gwt-code-reviews.appspot.com/612803/diff/1/6 File user/src/com/google/gwt/uibinder/attributeparsers/TextAlignConstantParser.java (right): http://gwt-code-reviews.appspot.com/612803/diff/1/6#newcode29 user/src/com/google/gwt/uibinder/attributeparsers/TextAlignConstantParser.java:29: private static final String PREFIX = "com.google.gwt.user.client.ui.TextBoxBase.ALIGN_"; Another spot to use the class's name, TextBoxBase.class.getName() + ALIGN_ http://gwt-code-reviews.appspot.com/612803/diff/1/6#newcode36 user/src/com/google/gwt/uibinder/attributeparsers/TextAlignConstantParser.java:36: values.put("justify", PREFIX + "JUSTIFY"); Seems like we should also accept the ugly names. http://gwt-code-reviews.appspot.com/612803/diff/1/2 File user/test/com/google/gwt/uibinder/UiBinderJreSuite.java (right): http://gwt-code-reviews.appspot.com/612803/diff/1/2#newcode26 user/test/com/google/gwt/uibinder/UiBinderJreSuite.java:26: import com.google.gwt.uibinder.attributeparsers.TextAlignConstantParser_Test; There shouldn't be an underscore in the name (the one in VerticalAlignment... is a mistake). http://gwt-code-reviews.appspot.com/612803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
