Reviewers: jat,
Description:
Fix external issue 5100 - use numeric value to access a hash map entry
due to a bug in FireFox
Please review this at http://gwt-code-reviews.appspot.com/672802/show
Affected files:
M user/super/com/google/gwt/emul/java/util/AbstractHashMap.java
Index: user/super/com/google/gwt/emul/java/util/AbstractHashMap.java
===================================================================
--- user/super/com/google/gwt/emul/java/util/AbstractHashMap.java (revision
8389)
+++ user/super/com/google/gwt/emul/java/util/AbstractHashMap.java (working
copy)
@@ -276,8 +276,9 @@
var hashCodeMap = [email protected]::hashCodeMap;
for (var hashCode in hashCodeMap) {
// sanity check that it's really an integer
- if (hashCode == parseInt(hashCode, 10)) {
- var array = hashCodeMap[hashCode];
+ var hashCodeInt = parseInt(hashCode, 10);
+ if (hashCode == hashCodeInt) {
+ var array = hashCodeMap[hashCodeInt];
for (var i = 0, c = array.length; i < c; ++i) {
[email protected]::add(Ljava/lang/Object;)(array[i]);
}
@@ -312,8 +313,9 @@
var hashCodeMap = [email protected]::hashCodeMap;
for (var hashCode in hashCodeMap) {
// sanity check that it's really one of ours
- if (hashCode == parseInt(hashCode, 10)) {
- var array = hashCodeMap[hashCode];
+ var hashCodeInt = parseInt(hashCode, 10);
+ if (hashCode == hashCodeInt) {
+ var array = hashCodeMap[hashCodeInt];
for (var i = 0, c = array.length; i < c; ++i) {
var entry = array[i];
var entryValue = [email protected]$entry::getValue()();
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
