Yes, that's a flat out bug. Would you mind filing a ticket against Roo, with
component GWT?

http://jira.springframework.org/secure/CreateIssue.jspa?pid=10340&issuetype=1


On Thu, Jul 22, 2010 at 12:15 PM, pjulien <[email protected]> wrote:

> I understand your point about EditorSupport but I still feel one issue
> was missed/dismissed in your reply.   That is, the fact that we can't
> currently inherit records from other records right now because the
> getters are not re-generated in the leaf.  Is this something that we
> can currently consider a bug?
>
> On Jul 22, 2:24 pm, Ray Ryan <[email protected]> wrote:
> > Please don't get too attached to EditorSupport. It was a last minute hack
> > without a lot of thought behind it. A ground-up rewrite is in progress.
> > We'll share details soon.
> >
> > RequestFactory too is undergoing surgery, perhttps://
> wave.google.com/wave/waveref/googlewave.com/w+WU4iAICkI
> >
> > Not that I want to discourage people from trying this out and giving us
> > feedback! But please understand when we pull the rug out from under you.
> >
> >
> >
> > On Thu, Jul 22, 2010 at 11:18 AM, Pascal Patry <[email protected]>
> wrote:
> > > On Thursday, July 22, 2010 02:01:53 pm Ray Ryan wrote:
> > > > Thanks for the patch!
> >
> > > > We just noticed this ourselves, and a broader patch should soon go in
> > > that
> > > > includes this fix.
> >
> > > Great.. are we going to be able to extend a RequestFactory with this
> > > patch? I described the issue there:
> > >http://code.google.com/p/google-web-toolkit/issues/detail?id=5134
> >
> > > We also have the same issues with the Record. We have one common Record
> > > for basic functions that we inherit from others. The problem here is
> > > that the Impl won't implement getters for the inherited types.
> > >http://code.google.com/p/google-web-toolkit/issues/detail?id=5136
> >
> > > We can always work around this by using get(obj.property) instead of
> the
> > > getters, but EditorSupport really try to use the getters to set the
> > > values in the UI.
> >
> > > > On Thu, Jul 22, 2010 at 7:59 AM, <[email protected]> wrote:
> > > > > Reviewers: ,
> >
> > > > > Description:
> > > > > When more than one RequestFactory is created, we are getting
> compiling
> > > > > errors because some of the records are not in the same package than
> the
> > > > > actual request factory. To fix this, we simply add all the imports
> to
> > > > > the RequestFactoryGenerator in order to know where to find these
> > > > > records.
> >
> > > > > Please review this athttp://
> gwt-code-reviews.appspot.com/653802/show
> >
> > > > > Affected files:
> >
> > >
>  user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.ja
> > > > >  va
> >
> > > > > Index:
> >
> > >
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.jav
> > > > > a
> ===================================================================
> > > ---
> >
> > >
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.jav
> > > > > a
> >
> > > > >  (revision 8401)
> >
> > > > > +++
> >
> > >
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.jav
> > > > > a
> >
> > > > >  (working copy)
> >
> > > > > @@ -315,6 +315,12 @@
> >
> > > > >     f.addImport(interfaceType.getQualifiedSourceName());
> > > > >     f.addImport(Record.class.getName());
> > > > >     f.addImport(RecordSchema.class.getName());
> >
> > > > > +
> > > > > +    for (JClassType publicRecordType : generatedRecordTypes) {
> > > > > +        f.addImport(publicRecordType.getPackage().getName() + "."
> +
> > > > > publicRecordType.getName());
> > > > > +        f.addImport(publicRecordType.getPackage().getName() + "."
> +
> > > > > publicRecordType.getName() + "Impl");
> > > > > +    }
> > > > > +
> >
> > > > >     f.addImplementedInterface(interfaceType.getName());
> >
> > > > >     f.addImplementedInterface(interfaceType.getName());
> >
> > > > > --
> > > > >http://groups.google.com/group/Google-Web-Toolkit-Contributors
> >
> > > --
> > >http://groups.google.com/group/Google-Web-Toolkit-Contributors
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to