LGTM with one nit

http://gwt-code-reviews.appspot.com/651803/diff/3001/4001
File bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/651803/diff/3001/4001#newcode28
bikeshed/src/com/google/gwt/sample/expenses/gwt/Scaffold.gwt.xml:28:
than the system handler, so only that one is enabled for now -->
Are all of these things really enabled by default? Not that I'm against
including them here, they're great documentation, but I'm curious.

http://gwt-code-reviews.appspot.com/651803/diff/3001/4002
File
user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
(right):

http://gwt-code-reviews.appspot.com/651803/diff/3001/4002#newcode59
user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java:59:
setLevel(Level.INFO);
How about providing an alternate constructor that accepts a Level
argument, and make this comment its javadoc?

http://gwt-code-reviews.appspot.com/651803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to