Revision: 8415
Author: [email protected]
Date: Mon Jul 26 11:12:39 2010
Log: Fix external issue 5062 - DateTimeFormat#formatFractionalSeconds
incorrect for date before 1970 with 0 fractionalSecond
Review at http://gwt-code-reviews.appspot.com/715801
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=8415
Modified:
/trunk/user/src/com/google/gwt/i18n/client/DateTimeFormat.java
/trunk/user/test/com/google/gwt/i18n/client/DateTimeFormat_en_Test.java
=======================================
--- /trunk/user/src/com/google/gwt/i18n/client/DateTimeFormat.java Fri Jun
25 07:49:33 2010
+++ /trunk/user/src/com/google/gwt/i18n/client/DateTimeFormat.java Mon Jul
26 11:12:39 2010
@@ -1254,6 +1254,9 @@
int value;
if (time < 0) {
value = 1000 - (int) (-time % 1000);
+ if (value == 1000) {
+ value = 0;
+ }
} else {
value = (int) (time % 1000);
}
=======================================
--- /trunk/user/test/com/google/gwt/i18n/client/DateTimeFormat_en_Test.java
Fri Jun 25 07:49:33 2010
+++ /trunk/user/test/com/google/gwt/i18n/client/DateTimeFormat_en_Test.java
Mon Jul 26 11:12:39 2010
@@ -542,6 +542,9 @@
assertEquals("055", DateTimeFormat.getFormat("SSS").format(date, utc));
assertEquals("06", DateTimeFormat.getFormat("SS").format(date, utc));
assertEquals("1", DateTimeFormat.getFormat("S").format(date, utc));
+
+ date = new Date(midnight);
+ assertEquals("000", DateTimeFormat.getFormat("SSS").format(date, utc));
}
public void testZeroPadYear() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
