Thanks! Looks great, just a couple of nits.

http://gwt-code-reviews.appspot.com/715802/diff/1/3
File
user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java
(right):

http://gwt-code-reviews.appspot.com/715802/diff/1/3#newcode37
user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java:37:
///////////////////////////////////////////////////////////////////////////
I didn't say anything in previous CLs, but we really don't do this type
of method grouping. In most of our code we follow alphabetical sorting,
for good or for ill, and folks frequently auto sort tests too (though
that's not strictly required by our style guide). Would you mind
dropping the groups?

http://gwt-code-reviews.appspot.com/715802/diff/1/3#newcode114
user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java:114:
b.append("  <g:position left='1' top='2'>");
Could you make this g:child? And could you test having several children?

http://gwt-code-reviews.appspot.com/715802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to