LGTM w/ nits.

http://gwt-code-reviews.appspot.com/719801/diff/1/12
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode62
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:62:
List<String> data = Lists.create();
Might be slightly faster to initialize this in the ctor when you
actually have the data available, as Lists.create(data).

http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode81
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:81:
for (int i = 0; i < data.length; i++) {
This loop is just Lists.addAll(this.data, data)

http://gwt-code-reviews.appspot.com/719801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to