Revision: 8422
Author: [email protected]
Date: Tue Jul 27 18:10:49 2010
Log: 3 small things:
(a) fix checkstyle failures in bikeshed,
(b) invoke checkstyle in bikeshed when checkstyle is run in trunk,
(c) remove unnecessary @Override
Patch by: amitmanjhi,unnurg
Review by: unnurg,amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=8422
Modified:
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/request/UserInformationRecord.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
/trunk/build.xml
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
Fri Jul 23 15:42:40 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
Tue Jul 27 18:10:49 2010
@@ -89,8 +89,8 @@
login.setUserInformation(userInformationRecord);
}
};
- requestFactory.userInformationRequest()
- .getCurrentUserInformation().to(receiver).fire();
+
requestFactory.userInformationRequest().getCurrentUserInformation().to(
+ receiver).fire();
/* Left side lets us pick from all the types of entities */
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/request/UserInformationRecord.java
Fri Jul 23 10:49:57 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/request/UserInformationRecord.java
Tue Jul 27 18:10:49 2010
@@ -39,7 +39,9 @@
Property<String> name =
new Property<String>("name", "Name", String.class);
- // Most of the actual getXxx calls come from the UserInformationProvider
- // interface
+ /* Most of the actual getXxx calls come from the UserInformationProvider
+ * interface. Redeclare this method, even though it is already in
Record.java
+ * so checkstyle does not complain about an interface with no methods */
+ String getId();
}
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
Fri Jul 23 10:49:57 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
Tue Jul 27 18:10:49 2010
@@ -23,7 +23,7 @@
/**
* A user information class that uses the Google App Engine authentication
- * framework
+ * framework.
*/
public class GaeUserInformation extends UserInformationImpl {
private static UserService userService =
UserServiceFactory.getUserService();
@@ -40,6 +40,14 @@
return user.getEmail();
}
+ public Long getId() {
+ User user = userService.getCurrentUser();
+ if (user == null) {
+ return 0L;
+ }
+ return new Long(user.hashCode());
+ }
+
public String getLoginUrl() {
return userService.createLoginURL("RETURN_URL");
}
@@ -55,14 +63,6 @@
}
return user.getNickname();
}
-
- public Long getId() {
- User user = userService.getCurrentUser();
- if (user == null) {
- return 0L;
- }
- return new Long(user.hashCode());
- }
public boolean isUserLoggedIn() {
return userService.isUserLoggedIn();
=======================================
--- /trunk/build.xml Fri Jun 25 08:11:18 2010
+++ /trunk/build.xml Tue Jul 27 18:10:49 2010
@@ -116,6 +116,7 @@
</target>
<target name="checkstyle" description="[action] Does static analysis of
GWT source">
+ <call-subproject subproject="bikeshed" subtarget="checkstyle" />
<call-subproject subproject="buildtools" subtarget="checkstyle" />
<call-subproject subproject="dev" subtarget="checkstyle" />
<call-subproject subproject="user" subtarget="checkstyle" />
=======================================
---
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
Mon Jul 26 15:35:20 2010
+++
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
Tue Jul 27 18:10:49 2010
@@ -27,11 +27,11 @@
import java.util.logging.Logger;
/**
- * A Handler that does Remote Logging for applications using Request
Factory
+ * A Handler that does Remote Logging for applications using Request
Factory.
*/
public class RequestFactoryLogHandler extends Handler {
class LoggingReceiver implements Receiver<Long> {
- @Override
+
public void onSuccess(Long response) {
if (response > 0) {
logger.finest("Remote logging successful");
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
