Looks great. In response to Matt's question about __COMPUTE_SCRIPT_BASE__, that replacement is done in SelectionScriptLinker.java. It's a fairly recent change to share more stuff among the various linkers -- though hopefully we'll be able to reduce the "various linkers" to one at some point :)
http://gwt-code-reviews.appspot.com/726802/diff/1/3 File dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js (right): http://gwt-code-reviews.appspot.com/726802/diff/1/3#newcode88 dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js:88: (query.indexOf('gwt.hybrid') == -1); On 2010/07/29 19:55:33, Matt Mastracci wrote:
Is it worth trimming the old gwt.hosted baggage from here?
It's kind of silly, but in the interest of keeping some old scripts around here (and doubtless outside of Google) working, I'd be ok with keeping it. http://gwt-code-reviews.appspot.com/726802/diff/1/3#newcode110 dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js:110: scriptFrame.style.cssText = 'position:absolute; width:0; height:0; border:none'; On 2010/07/29 19:55:33, Matt Mastracci wrote:
These should probably be !important to avoid user CSS accidentally
styling them.
Also, left: -1000px and top: -1000px, since absolute by default will
place them
at the end of the document potentially causing sizing issues.
I think Matt's right about this (and I should have done this ages ago). It's pretty defensive, but that's what you have to do in CSS-land :-/ http://gwt-code-reviews.appspot.com/726802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
