LGTM On Fri, Jul 30, 2010 at 10:52 AM, <[email protected]> wrote:
> Reviewers: Ray Ryan, > > Description: > Fixed 2 TODOs: (a) removed the RequestFactory variable from > AbstractRecordEditActivity, > (b) Removed all the nested interfaces from RequestFactory. > > Patch by: amitmanjhi > Review by: rjrjr > > > Please review this at http://gwt-code-reviews.appspot.com/731802/show > > Affected files: > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportEntry.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/request/EmployeeRequest.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpenseRequest.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRequest.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsActivity.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java > M user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java > M > user/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java > M > user/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java > M > user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java > M > user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java > M > user/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java > M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java > M > user/src/com/google/gwt/requestfactory/client/impl/AbstractVoidRequest.java > M > user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java > M user/src/com/google/gwt/requestfactory/server/OperationRegistry.java > M > user/src/com/google/gwt/requestfactory/server/ReflectionBasedOperationRegistry.java > A user/src/com/google/gwt/requestfactory/server/RequestDefinition.java > M user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java > M user/src/com/google/gwt/requestfactory/shared/LoggingRequest.java > M user/src/com/google/gwt/requestfactory/shared/RecordListRequest.java > M user/src/com/google/gwt/requestfactory/shared/RecordRequest.java > M user/src/com/google/gwt/requestfactory/shared/RequestFactory.java > A user/src/com/google/gwt/requestfactory/shared/RequestObject.java > M > user/test/com/google/gwt/requestfactory/server/ReflectionBasedOperationRegistryTest.java > M user/test/com/google/gwt/requestfactory/server/SimpleFooRequest.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
