Revision: 8446
Author: [email protected]
Date: Fri Jul 30 10:32:50 2010
Log: Fix warnings and checkstyle errors
Review at http://gwt-code-reviews.appspot.com/724801
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=8446
Modified:
/trunk/dev/core/src/com/google/gwt/dev/jdt/TypeRefVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
/trunk/user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
/trunk/user/src/com/google/gwt/app/place/Activity.java
/trunk/user/src/com/google/gwt/i18n/client/BidiPolicy.java
/trunk/user/src/com/google/gwt/junit/JUnitShell.java
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
/trunk/user/src/com/google/gwt/requestfactory/server/Logging.java
/trunk/user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
/trunk/user/src/com/google/gwt/user/client/ui/ValueBox.java
/trunk/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jdt/TypeRefVisitor.java Fri Jul
9 10:56:34 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jdt/TypeRefVisitor.java Fri Jul
30 10:32:50 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.dev.jdt;
-
import org.eclipse.jdt.internal.compiler.ast.ArrayQualifiedTypeReference;
import org.eclipse.jdt.internal.compiler.ast.ArrayTypeReference;
import org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration;
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Thu Jul 29 04:13:58 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Fri Jul 30 10:32:50 2010
@@ -1018,7 +1018,6 @@
soycArtifacts.add(splitPoints);
SpeedTracerLogger.end(CompilerEventType.MAKE_SOYC_ARTIFACTS);
-
SyntheticArtifact sizeMaps = null;
if (sizeBreakdowns != null) {
SpeedTracerLogger.start(CompilerEventType.MAKE_SOYC_ARTIFACTS,
=======================================
---
/trunk/user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
Wed Jul 28 16:39:40 2010
+++
/trunk/user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
Fri Jul 30 10:32:50 2010
@@ -174,7 +174,7 @@
* Called to fetch the string token needed to get a new record via
* {...@link DeltaValueStore#create}.
*/
- protected abstract Class getRecordClass();
+ protected abstract Class<? extends Record> getRecordClass();
private void doStart(final Display display, R record) {
view.setEnabled(true);
=======================================
--- /trunk/user/src/com/google/gwt/app/place/Activity.java Fri Jul 16
07:47:49 2010
+++ /trunk/user/src/com/google/gwt/app/place/Activity.java Fri Jul 30
10:32:50 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.app.place;
-
/**
* <p>
* <span style="color:red">Experimental API: This class is still under
rapid
=======================================
--- /trunk/user/src/com/google/gwt/i18n/client/BidiPolicy.java Sun Jun 20
09:43:54 2010
+++ /trunk/user/src/com/google/gwt/i18n/client/BidiPolicy.java Fri Jul 30
10:32:50 2010
@@ -33,7 +33,6 @@
/**
* Implementation class for {...@link BidiPolicy} used when bidi is always
on.
*/
- @SuppressWarnings("unused")
public static class BidiPolicyImplOn extends BidiPolicyImpl {
@Override
public boolean isBidiEnabled() {
=======================================
--- /trunk/user/src/com/google/gwt/junit/JUnitShell.java Tue Jul 27
17:24:40 2010
+++ /trunk/user/src/com/google/gwt/junit/JUnitShell.java Fri Jul 30
10:32:50 2010
@@ -530,7 +530,6 @@
* system classloader to dominate. This makes JUnitHostImpl live in the
* right classloader (mine).
*/
- @SuppressWarnings("unchecked")
@Override
protected WebAppContext createWebAppContext(TreeLogger logger,
File appRootDir) {
=======================================
---
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
Wed Jul 28 16:39:40 2010
+++
/trunk/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
Fri Jul 30 10:32:50 2010
@@ -29,7 +29,7 @@
import java.util.logging.Logger;
/**
- * A Handler that does Remote Logging for applications using Request
Factory.
+ * A Handler that does remote logging for applications using
RequestFactory.
*/
public class RequestFactoryLogHandler extends Handler {
class LoggingReceiver implements Receiver<Long> {
@@ -82,11 +82,11 @@
// something more complex than Strings to the logMessage function,
then
// we can do batching here.
for (LogRecord record : records) {
- Receiver<Long> loggingReciever = new LoggingReceiver();
+ Receiver<Long> loggingReceiver = new LoggingReceiver();
requestFactory.loggingRequest().logMessage(
record.getLevel().toString(),
record.getLoggerName(),
- record.getMessage()).fire(loggingReciever);
+ record.getMessage()).fire(loggingReceiver);
}
}
}
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/server/Logging.java Mon
Jul 26 15:35:20 2010
+++ /trunk/user/src/com/google/gwt/requestfactory/server/Logging.java Fri
Jul 30 10:32:50 2010
@@ -21,7 +21,7 @@
/**
* Server side object that handles log messages sent by
- * {...@requestfactoryloghandler}
+ * {...@link RequestFactoryLogHandler}.
*/
public class Logging {
private static Logger logger = Logger.getLogger(Logging.class.getName());
=======================================
---
/trunk/user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
Fri Jul 23 15:42:40 2010
+++
/trunk/user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
Fri Jul 30 10:32:50 2010
@@ -189,7 +189,7 @@
* @param key the key of the record field
* @return the ID of the new record, or null to auto generate
*/
- protected Long generateIdForCreate(@SuppressWarnings("unused") String
key) {
+ protected Long generateIdForCreate(String key) {
// ignored. id is assigned by default.
return null;
}
=======================================
--- /trunk/user/src/com/google/gwt/user/client/ui/ValueBox.java Fri Jun 18
20:16:34 2010
+++ /trunk/user/src/com/google/gwt/user/client/ui/ValueBox.java Fri Jul 30
07:51:15 2010
@@ -19,7 +19,6 @@
import com.google.gwt.dom.client.Element;
import com.google.gwt.dom.client.InputElement;
import com.google.gwt.i18n.client.BidiUtils;
-import com.google.gwt.i18n.client.HasDirection;
import com.google.gwt.text.shared.Parser;
import com.google.gwt.text.shared.Renderer;
@@ -32,7 +31,7 @@
*
* @param <T> the value type
*/
-public class ValueBox<T> extends ValueBoxBase<T> implements HasDirection {
+public class ValueBox<T> extends ValueBoxBase<T> {
/**
* Creates a ValueBox widget that wraps an existing <input
type='text'>
=======================================
--- /trunk/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java
Sun Jun 20 09:43:54 2010
+++ /trunk/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java
Fri Jul 30 07:51:15 2010
@@ -133,7 +133,7 @@
}
/**
- * Failed in all modes due to HtmlUnit bug:
+ * Failed in all modes due to HtmlUnit bug.
*/
@DoNotRunWith({Platform.HtmlUnitBug})
public void testValueChangeEvent() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
