http://gwt-code-reviews.appspot.com/710802/diff/1/9
File user/src/com/google/gwt/user/cellview/client/CellTable.java
(right):

http://gwt-code-reviews.appspot.com/710802/diff/1/9#newcode527
user/src/com/google/gwt/user/cellview/client/CellTable.java:527:
focusable.focus();
I think we should only focus on user initiated events.  If we focus on
the table on initialization, it may steal focus from another widget,
such as a search box.

http://gwt-code-reviews.appspot.com/710802/diff/1/9#newcode757
user/src/com/google/gwt/user/cellview/client/CellTable.java:757:
view.setFocus();
SGTM

http://gwt-code-reviews.appspot.com/710802/diff/1/12
File
user/src/com/google/gwt/user/cellview/client/PagingListViewPresenter.java
(right):

http://gwt-code-reviews.appspot.com/710802/diff/1/12#newcode486
user/src/com/google/gwt/user/cellview/client/PagingListViewPresenter.java:486:
view.setFocus();
I missed that in the JavaDoc comment on setFocus().  Even though this is
all package protected, the method name is a little misleading.  Can we
rename it to resetFocus()?

http://gwt-code-reviews.appspot.com/710802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to