LGTM

http://gwt-code-reviews.appspot.com/730801/diff/2001/3003
File dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java
(right):

http://gwt-code-reviews.appspot.com/730801/diff/2001/3003#newcode74
dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java:74:
return hasErrors;
Nit: it's a little weird that the getter doesn't match the field name.
Maybe use hasErrors for both?  It would also then match the JDT's
CompilationResult, which has a hasErrors() method.

http://gwt-code-reviews.appspot.com/730801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to