Reviewers: mmendez,
Description:
Made the error messages thrown in case of GWTTestCase timeouts more
informative, as requested in
http://code.google.com/p/google-web-toolkit/issues/detail?id=4099
Patch by: amitmanjhi
Review by: mmendez
Please review this at http://gwt-code-reviews.appspot.com/734801/show
Affected files:
M user/src/com/google/gwt/junit/JUnitShell.java
Index: user/src/com/google/gwt/junit/JUnitShell.java
===================================================================
--- user/src/com/google/gwt/junit/JUnitShell.java (revision 8450)
+++ user/src/com/google/gwt/junit/JUnitShell.java (working copy)
@@ -1015,7 +1015,8 @@
+ testBatchingMethodTimeoutMillis
+ "ms.\n We have no results from:\n"
+ messageQueue.getWorkingClients(currentTestInfo)
- + "Actual time elapsed: " + elapsed + " seconds.\n");
+ + "Actual time elapsed: " + elapsed + " seconds.\n"
+ + "Try increasing this timeout using
the '-testMethodTimeout number' option\n");
}
} else if (testBeginTimeout < currentTimeMillis) {
double elapsed = (currentTimeMillis - testBeginTime) / 1000.0;
@@ -1023,7 +1024,9 @@
"The browser did not contact the server within "
+ baseTestBeginTimeoutMillis + "ms.\n"
+ messageQueue.getUnretrievedClients(currentTestInfo)
- + "\n Actual time elapsed: " + elapsed + " seconds.\n");
+ + "\n Actual time elapsed: " + elapsed + " seconds.\n"
+ + "Try increasing this timeout using the '-testBeginTimeout
number' option\n"
+ + "The default value of number is 1, i.e., the server waits
1 minute or 60 seconds.\n");
}
// Check that we haven't lost communication with a remote host.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors