New patch uploaded.
http://gwt-code-reviews.appspot.com/733802/diff/1/3
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayCheckBox.java
(right):
http://gwt-code-reviews.appspot.com/733802/diff/1/3#newcode38
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayCheckBox.java:38:
On 2010/08/02 18:29:19, Ray Ryan wrote:
Note that in a real app we would need to think about a way to
de-register when
detached.
Done.
http://gwt-code-reviews.appspot.com/733802/diff/1/5
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml
(right):
http://gwt-code-reviews.appspot.com/733802/diff/1/5#newcode16
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml:16:
<ui:with type="com.google.gwt.event.shared.HandlerManager"
field="eventBus"></ui:with>
On 2010/08/02 18:29:19, Ray Ryan wrote:
This is still hacky. It would be better to put a @UiFactory method in
DayFilterWidget:
@UiFactory
DayCheckBox makeCheckBox
If that's not practical, then I withdraw my objection to
DynaTableEventBus.get(), especially if you do something like:
/**
* Instantiate a DayCheckBox using the default event bus
* at {...@link DynaTableEventBus#get}. A production app
* would be better off using a dependency injection
* framework, like <a
* href="http://code.google.com/p/google-gin/";>Google GIN</a>
*/
public DayCheckBox() {
DayCheckBox(DynaTableEventBus.get());
}
public DayCheckBox(HandlerManager eventBus) {
this.eventBus = eventBus;
}
Done.
http://gwt-code-reviews.appspot.com/733802/diff/1/8
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.ui.xml
(right):
http://gwt-code-reviews.appspot.com/733802/diff/1/8#newcode18
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.ui.xml:18:
<ui:with type="com.google.gwt.event.shared.HandlerManager"
field="eventBus" />
On 2010/08/02 18:29:19, Ray Ryan wrote:
Another spot to prefer @UiFactory or @UiField(provided=true)
Done.
http://gwt-code-reviews.appspot.com/733802/diff/1/16
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/events/NavigationEventHandler.java
(right):
http://gwt-code-reviews.appspot.com/733802/diff/1/16#newcode23
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/events/NavigationEventHandler.java:23:
public interface NavigationEventHandler extends EventHandler {
On 2010/08/02 18:29:19, Ray Ryan wrote:
Style nit, I really prefer handlers to be declared inside the
appropriate event.
I find it much more readable, especially for those new to our event
system. So
this would be NavigationEvent.Handler
Done.
http://gwt-code-reviews.appspot.com/733802/diff/1/17
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/events/RequestRowDataEvent.java
(right):
http://gwt-code-reviews.appspot.com/733802/diff/1/17#newcode21
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/events/RequestRowDataEvent.java:21:
* A request for data to be fetched from the server.
On 2010/08/02 18:29:19, Ray Ryan wrote:
I wouldn't normally do this kind of thing over the event bus. Rather,
the
requestfactory itself would be injected into the data provider.
Done.
http://gwt-code-reviews.appspot.com/733802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
