http://gwt-code-reviews.appspot.com/722802/diff/1/2
File user/src/com/google/gwt/view/client/DefaultSelectionModel.java
(right):

http://gwt-code-reviews.appspot.com/722802/diff/1/2#newcode84
user/src/com/google/gwt/view/client/DefaultSelectionModel.java:84:
scheduleSelectionChangeEvent();
Should you be doing this at your "finally" spot rather than at each
setSelected() call?

http://gwt-code-reviews.appspot.com/722802/diff/1/3
File user/src/com/google/gwt/view/client/MultiSelectionModel.java
(right):

http://gwt-code-reviews.appspot.com/722802/diff/1/3#newcode52
user/src/com/google/gwt/view/client/MultiSelectionModel.java:52: public
void setSelected(T object, boolean selected) {
I'm confused by this one. setSelected is also a way to notify the model
that an object is still selected, but needs to be redisplayed because it
has changed?

http://gwt-code-reviews.appspot.com/722802/diff/1/4
File user/src/com/google/gwt/view/client/NoSelectionModel.java (right):

http://gwt-code-reviews.appspot.com/722802/diff/1/4#newcode49
user/src/com/google/gwt/view/client/NoSelectionModel.java:49: public
void setSelected(T object, boolean selected) {
Seems like de-bouncing would be unexpected for this model?

http://gwt-code-reviews.appspot.com/722802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to