Thanks, Bob
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003#newcode35
user/src/com/google/gwt/resources/client/DataResource.java:35: *
Specifies the resource or resources associated with the
On 2010/08/03 13:15:30, bobv wrote:
Specifies that the
Done.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6012
File
user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java
(right):
http://gwt-code-reviews.appspot.com/714801/diff/48001/6012#newcode22
user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java:22:
* Tests for <code>@link DataResource.DoNotEmbed @DoNotEmbed}</code>
resource
On 2010/08/03 13:15:30, bobv wrote:
Check the formatting of that @link.
Done.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6012#newcode67
user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java:67:
// Skip this test for browsers which do not support data URLs
On 2010/08/03 13:15:30, bobv wrote:
return; here since it's an early out.
Remove the else block. Apply in the other test class.
Done.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6013
File
user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java
(right):
http://gwt-code-reviews.appspot.com/714801/diff/48001/6013#newcode22
user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java:22:
* Tests for <code>@link DataResource.MimeType @MimeType}</code> resource
On 2010/08/03 13:15:30, bobv wrote:
Weird formatting with the @link here.
Done.
After fixing this numerous times, I figured out what the problem was:
the fact that I had wrapped the {...@link ...} in code tags was causing the
Eclipse auto formatter (CTRL-SHIFT-F) to remove the beginning '{'.
I removed unncessary <code> tags in both files and auto-format is
happier.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6013#newcode27
user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java:27:
static interface Resources extends ClientBundle {
On 2010/08/03 13:15:30, bobv wrote:
interfaces are implicitly static
Done.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6013#newcode34
user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java:34:
static final String FOUR_ZEROS_SOURCE = "fourZeros.dat";
On 2010/08/03 13:15:30, bobv wrote:
Remove the "static final" modifiers, since that's implicit.
Done.
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
