http://gwt-code-reviews.appspot.com/735801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right):
http://gwt-code-reviews.appspot.com/735801/diff/1/2#newcode81 tools/api-checker/config/gwt20_21userApi.conf:81: :user/src/com/google/gwt/validation/client/constraints/*.java\ On 2010/08/03 17:44:59, Ray Ryan wrote:
This doesn't belong here. You'll prevent the api checker from warning
us of
future changes to this public api.
I get compile trying to run apicheck without this http://gwt-code-reviews.appspot.com/735801/diff/1/3 File user/build.xml (right): http://gwt-code-reviews.appspot.com/735801/diff/1/3#newcode135 user/build.xml:135: <exclude name="javax/validation/super/javax/validation/constraints/Pattern.java"/> On 2010/08/03 17:44:59, Ray Ryan wrote:
No tabs, please.
Done. http://gwt-code-reviews.appspot.com/735801/diff/5001/6001 File tools/api-checker/config/gwt20_21userApi.conf (right): http://gwt-code-reviews.appspot.com/735801/diff/5001/6001#newcode81 tools/api-checker/config/gwt20_21userApi.conf:81: :user/src/com/google/gwt/validation/client/constraints/*.java\ deleted. I swear I use to get compile errors with out this. http://gwt-code-reviews.appspot.com/735801/diff/5001/6012 File user/src/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumber.java (right): http://gwt-code-reviews.appspot.com/735801/diff/5001/6012#newcode33 user/src/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumber.java:33: } else if (value instanceof BigDecimal) { On 2010/08/03 17:44:59, Ray Ryan wrote:
pet peeve: there is no reason for an else after a return
Done. http://gwt-code-reviews.appspot.com/735801/diff/5001/6012#newcode34 user/src/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumber.java:34: BigDecimal bigValue = (BigDecimal) value; On 2010/08/03 17:44:59, Ray Ryan wrote:
should inline
Done. http://gwt-code-reviews.appspot.com/735801/diff/5001/6016 File user/src/com/google/gwt/validation/client/constraints/DefaultConstraints.java (right): http://gwt-code-reviews.appspot.com/735801/diff/5001/6016#newcode40 user/src/com/google/gwt/validation/client/constraints/DefaultConstraints.java:40: public class DefaultConstraints { On 2010/08/03 17:44:59, Ray Ryan wrote:
The compiler can't optimize this. Every class that you're using here
will be
compiled into every app that calls getDefaultConstraints.
Your right this belongs in the code generator. Deleted. http://gwt-code-reviews.appspot.com/735801/diff/5001/6019 File user/src/com/google/gwt/validation/client/constraints/FutureValidatorForDate.java (right): http://gwt-code-reviews.appspot.com/735801/diff/5001/6019#newcode26 user/src/com/google/gwt/validation/client/constraints/FutureValidatorForDate.java:26: * {...@link java.util.Date}. . On 2010/08/03 17:44:59, Ray Ryan wrote:
Extra period.
Done. http://gwt-code-reviews.appspot.com/735801/diff/5001/6023 File user/src/com/google/gwt/validation/client/constraints/MinValidatorForString.java (right): http://gwt-code-reviews.appspot.com/735801/diff/5001/6023#newcode34 user/src/com/google/gwt/validation/client/constraints/MinValidatorForString.java:34: bigValue = new BigDecimal(value); On 2010/08/03 17:44:59, Ray Ryan wrote:
Aren't there localization issues with this approach? Or is this
implementation
to spec?
The spec seems to be silent on this. For max/min value of the annotation it is specified as BigDecimal format. But nothing is said about String fields that are annotated by this constraint. All locale references seem to releate to MessageInterpolation. I will need search some more. Leaving a TODO http://gwt-code-reviews.appspot.com/735801/diff/5001/6027 File user/src/com/google/gwt/validation/client/constraints/PatternValidator.java (right): http://gwt-code-reviews.appspot.com/735801/diff/5001/6027#newcode26 user/src/com/google/gwt/validation/client/constraints/PatternValidator.java:26: * {...@link Pattern} constraint validator implementation. On 2010/08/03 17:44:59, Ray Ryan wrote:
Is this the place to mention the differences between gwt regexp and
real java
regexp? Maybe @link to com.google.gwt.regexp.shared.RegExp if nothing
else? Done. http://gwt-code-reviews.appspot.com/735801/diff/5001/6041 File user/src/javax/validation/super/javax/validation/constraints/Pattern.java (right): http://gwt-code-reviews.appspot.com/735801/diff/5001/6041#newcode16 user/src/javax/validation/super/javax/validation/constraints/Pattern.java:16: // Modified bu google. On 2010/08/03 17:44:59, Ray Ryan wrote:
bu
Done. http://gwt-code-reviews.appspot.com/735801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
