LGTM with nit.

http://gwt-code-reviews.appspot.com/728801/diff/7001/8015
File
dev/core/test/com/google/gwt/dev/resource/impl/ResourceOracleImplTest.java
(right):

http://gwt-code-reviews.appspot.com/728801/diff/7001/8015#newcode164
dev/core/test/com/google/gwt/dev/resource/impl/ResourceOracleImplTest.java:164:
}
You can simplify this whole section a lot by using
Util.readStreamAsBytes() or Util.readStreamAsString() and comparing the
results.

http://gwt-code-reviews.appspot.com/728801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to