http://gwt-code-reviews.appspot.com/704803/diff/1/2
File dev/core/src/com/google/gwt/dev/Compiler.java (right):

http://gwt-code-reviews.appspot.com/704803/diff/1/2#newcode207
dev/core/src/com/google/gwt/dev/Compiler.java:207: Event
precompileEventEvent =
SpeedTracerLogger.start(CompilerEventType.PRECOMPILE);
Did you mean this to be named with the double suffix EventEvent?

http://gwt-code-reviews.appspot.com/704803/diff/1/2#newcode211
dev/core/src/com/google/gwt/dev/Compiler.java:211:
SpeedTracerLogger.end(precompileEventEvent);
what do you think about changing this to

precompileEvent.end()

http://gwt-code-reviews.appspot.com/704803/diff/1/23
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/704803/diff/1/23#newcode196
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:196:
public static void end(Event event, String... data) {
I'm not sure we need a static method anymore, because the event argument
is sufficient.

http://gwt-code-reviews.appspot.com/704803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to