LGTM

On Thu, Aug 5, 2010 at 5:32 PM, <[email protected]> wrote:

> Reviewers: Ray Ryan,
>
> Description:
> Another step towards making instance methods real. The interface on the
> client is pretty much what it needs to be.
>
> EmployeeRequest has a method like
> RequestObject<Void> remove(EmployeeRecord record);
>
> However, there is a hack in place to get it to work on the server. (The
> hack was already there, this patch just moves it around.)
>
> Patch by: amitmanjhi
> Review by: rjrjr (desk review)
>
>
> Please review this at http://gwt-code-reviews.appspot.com/710803/show
>
> Affected files:
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseDetails.java
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportEntry.java
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/request/EmployeeRequest.java
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ReportRequest.java
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsActivity.java
>  M
> bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java
>  M user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
>  M
> user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
>  M
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
>  M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
>  M user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>  M user/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java
>  A user/src/com/google/gwt/requestfactory/shared/RequestData.java
>  M user/src/com/google/gwt/requestfactory/shared/RequestObject.java
>  D
> user/src/com/google/gwt/requestfactory/shared/impl/JsonRequestDataUtil.java
>  M
> user/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java
>  M
> user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to