Revision: 8504
Author: [email protected]
Date: Mon Aug  9 07:41:33 2010
Log: Refactor SelectionModel.SelectionEvent into its own class with associated Handler

Review at http://gwt-code-reviews.appspot.com/698804

http://code.google.com/p/google-web-toolkit/source/detail?r=8504

Added:
 /trunk/user/src/com/google/gwt/view/client/SelectionChangeEvent.java
Modified:
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseList.java /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseTree.java /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportList.java /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellBrowser.java /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellList.java /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTree.java
 /trunk/user/src/com/google/gwt/app/client/CellListPlacePickerView.java
/trunk/user/src/com/google/gwt/user/cellview/client/PagingListViewPresenter.java
 /trunk/user/src/com/google/gwt/view/client/SelectionModel.java
 /trunk/user/test/com/google/gwt/view/client/AbstractSelectionModelTest.java
 /trunk/user/test/com/google/gwt/view/client/DefaultSelectionModelTest.java
 /trunk/user/test/com/google/gwt/view/client/MockPagingListView.java
 /trunk/user/test/com/google/gwt/view/client/MultiSelectionModelTest.java
 /trunk/user/test/com/google/gwt/view/client/NoSelectionModelTest.java
 /trunk/user/test/com/google/gwt/view/client/SingleSelectionModelTest.java

=======================================
--- /dev/null
+++ /trunk/user/src/com/google/gwt/view/client/SelectionChangeEvent.java Mon Aug 9 07:41:33 2010
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.gwt.view.client;
+
+import com.google.gwt.event.shared.EventHandler;
+import com.google.gwt.event.shared.GwtEvent;
+
+/**
+ * Represents a selection change event.
+ */
+public class SelectionChangeEvent extends
+    GwtEvent<SelectionChangeEvent.Handler> {
+
+  /**
+   * Handler interface for {...@link SelectionChangeEvent} events.
+   */
+  public static interface Handler extends EventHandler {
+
+    /**
+     * Called when {...@link SelectionChangeEvent} is fired.
+     *
+     * @param event the {...@link SelectionChangeEvent} that was fired
+     */
+    void onSelectionChange(SelectionChangeEvent event);
+  }
+
+  /**
+   * Handler type.
+   */
+  private static Type<SelectionChangeEvent.Handler> TYPE;
+
+  /**
+ * Fires a selection change event on all registered handlers in the handler
+   * manager. If no such handlers exist, this method will do nothing.
+   *
+   * @param source the source of the handlers
+   */
+  public static void fire(SelectionModel<?> source) {
+    if (TYPE != null) {
+      SelectionChangeEvent event = new SelectionChangeEvent();
+      source.fireEvent(event);
+    }
+  }
+
+  /**
+   * Gets the type associated with this event.
+   *
+   * @return returns the handler type
+   */
+  public static Type<SelectionChangeEvent.Handler> getType() {
+    if (TYPE == null) {
+      TYPE = new Type<SelectionChangeEvent.Handler>();
+    }
+    return TYPE;
+  }
+
+  /**
+   * Creates a selection change event.
+   */
+  SelectionChangeEvent() {
+  }
+
+  @Override
+  public final Type<SelectionChangeEvent.Handler> getAssociatedType() {
+    return TYPE;
+  }
+
+  @Override
+  protected void dispatch(SelectionChangeEvent.Handler handler) {
+    handler.onSelectionChange(this);
+  }
+}
=======================================
--- /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseList.java Fri Jul 30 17:29:09 2010 +++ /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseList.java Mon Aug 9 07:41:33 2010
@@ -57,8 +57,7 @@
 import com.google.gwt.view.client.ListView;
 import com.google.gwt.view.client.NoSelectionModel;
 import com.google.gwt.view.client.Range;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;
+import com.google.gwt.view.client.SelectionChangeEvent;

 import java.util.ArrayList;
 import java.util.Date;
@@ -468,7 +467,7 @@
     // Add a selection model.
final NoSelectionModel<ReportRecord> selectionModel = new NoSelectionModel<ReportRecord>();
     table.setSelectionModel(selectionModel);
-    selectionModel.addSelectionChangeHandler(new SelectionChangeHandler() {
+ selectionModel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         Object selected = selectionModel.getLastSelectedObject();
         if (selected != null && listener != null) {
=======================================
--- /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseTree.java Wed Jul 28 16:39:40 2010 +++ /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpenseTree.java Mon Aug 9 07:41:33 2010
@@ -34,10 +34,9 @@
 import com.google.gwt.view.client.ListViewAdapter;
 import com.google.gwt.view.client.ProvidesKey;
 import com.google.gwt.view.client.Range;
+import com.google.gwt.view.client.SelectionChangeEvent;
 import com.google.gwt.view.client.SingleSelectionModel;
 import com.google.gwt.view.client.TreeViewModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;

 import java.util.ArrayList;
 import java.util.Collection;
@@ -255,7 +254,7 @@

// Listen for selection. We need to add this handler before the CellBrowser
     // adds its own handler.
-    selectionModel.addSelectionChangeHandler(new SelectionChangeHandler() {
+ selectionModel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         Object selected = selectionModel.getSelectedObject();
         if (selected == null) {
=======================================
--- /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java Fri Jul 30 17:29:09 2010 +++ /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java Mon Aug 9 07:41:33 2010
@@ -29,8 +29,7 @@
 import com.google.gwt.view.client.AsyncListViewAdapter;
 import com.google.gwt.view.client.ListView;
 import com.google.gwt.view.client.NoSelectionModel;
-import com.google.gwt.view.client.SelectionModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
+import com.google.gwt.view.client.SelectionChangeEvent;

 import java.util.ArrayList;
 import java.util.Collection;
@@ -139,7 +138,7 @@

     expenseSelection = new NoSelectionModel<ExpenseRecord>();
     expenseList.setSelectionModel(expenseSelection);
- expenseSelection.addSelectionChangeHandler(new SelectionModel.SelectionChangeHandler() { + expenseSelection.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
listener.onExpenseSelected(expenseSelection.getLastSelectedObject());
       }
=======================================
--- /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportList.java Wed Jul 28 16:39:40 2010 +++ /trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileReportList.java Mon Aug 9 07:41:33 2010
@@ -27,8 +27,7 @@
 import com.google.gwt.view.client.AsyncListViewAdapter;
 import com.google.gwt.view.client.ListView;
 import com.google.gwt.view.client.NoSelectionModel;
-import com.google.gwt.view.client.SelectionModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
+import com.google.gwt.view.client.SelectionChangeEvent;

 import java.util.ArrayList;
 import java.util.Collection;
@@ -83,7 +82,7 @@

     reportSelection = new NoSelectionModel<ReportRecord>();
     reportSelection.setKeyProvider(Expenses.REPORT_RECORD_KEY_PROVIDER);
- reportSelection.addSelectionChangeHandler(new SelectionModel.SelectionChangeHandler() { + reportSelection.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         listener.onReportSelected(reportSelection.getLastSelectedObject());
       }
=======================================
--- /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellBrowser.java Tue Jul 20 10:54:02 2010 +++ /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellBrowser.java Mon Aug 9 07:41:33 2010
@@ -30,8 +30,7 @@
 import com.google.gwt.user.client.ui.Label;
 import com.google.gwt.user.client.ui.Widget;
 import com.google.gwt.view.client.MultiSelectionModel;
-import com.google.gwt.view.client.SelectionModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
+import com.google.gwt.view.client.SelectionChangeEvent;

 import java.util.ArrayList;
 import java.util.Collections;
@@ -121,7 +120,7 @@
final MultiSelectionModel<ContactInfo> selectionModel = new MultiSelectionModel<ContactInfo>(); selectionModel.setKeyProvider(ContactDatabase.ContactInfo.KEY_PROVIDER);
     selectionModel.addSelectionChangeHandler(
-        new SelectionModel.SelectionChangeHandler() {
+        new SelectionChangeEvent.Handler() {
           public void onSelectionChange(SelectionChangeEvent event) {
             StringBuilder sb = new StringBuilder();
             boolean first = true;
=======================================
--- /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellList.java Tue Jul 20 10:54:02 2010 +++ /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellList.java Mon Aug 9 07:41:33 2010
@@ -36,8 +36,7 @@
 import com.google.gwt.user.client.ui.Button;
 import com.google.gwt.user.client.ui.ScrollPanel;
 import com.google.gwt.user.client.ui.Widget;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;
+import com.google.gwt.view.client.SelectionChangeEvent;
 import com.google.gwt.view.client.SingleSelectionModel;

 /**
@@ -204,7 +203,7 @@
     // Add a selection model so we can select cells.
final SingleSelectionModel<ContactInfo> selectionModel = new SingleSelectionModel<ContactInfo>();
     cellList.setSelectionModel(selectionModel);
-    selectionModel.addSelectionChangeHandler(new SelectionChangeHandler() {
+ selectionModel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         contactForm.setContact(selectionModel.getSelectedObject());
       }
=======================================
--- /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTree.java Tue Jul 20 10:54:02 2010 +++ /trunk/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTree.java Mon Aug 9 07:41:33 2010
@@ -30,8 +30,7 @@
 import com.google.gwt.user.client.ui.Label;
 import com.google.gwt.user.client.ui.Widget;
 import com.google.gwt.view.client.MultiSelectionModel;
-import com.google.gwt.view.client.SelectionModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
+import com.google.gwt.view.client.SelectionChangeEvent;

 import java.util.ArrayList;
 import java.util.Collections;
@@ -119,7 +118,7 @@
final MultiSelectionModel<ContactInfo> selectionModel = new MultiSelectionModel<ContactInfo>(); selectionModel.setKeyProvider(ContactDatabase.ContactInfo.KEY_PROVIDER);
     selectionModel.addSelectionChangeHandler(
-        new SelectionModel.SelectionChangeHandler() {
+        new SelectionChangeEvent.Handler() {
           public void onSelectionChange(SelectionChangeEvent event) {
             StringBuilder sb = new StringBuilder();
             boolean first = true;
=======================================
--- /trunk/user/src/com/google/gwt/app/client/CellListPlacePickerView.java Thu Jun 24 14:48:00 2010 +++ /trunk/user/src/com/google/gwt/app/client/CellListPlacePickerView.java Mon Aug 9 07:41:33 2010
@@ -21,9 +21,8 @@
 import com.google.gwt.text.shared.Renderer;
 import com.google.gwt.user.cellview.client.CellList;
 import com.google.gwt.user.client.ui.Composite;
+import com.google.gwt.view.client.SelectionChangeEvent;
 import com.google.gwt.view.client.SingleSelectionModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;

 import java.util.List;

@@ -57,7 +56,7 @@
     this.cellList = new CellList<P>(new CellRenderer());
     initWidget(cellList);
     cellList.setSelectionModel(smodel);
-    smodel.addSelectionChangeHandler(new SelectionChangeHandler() {
+    smodel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         if (listener != null) {
           listener.placePicked(smodel.getSelectedObject());
=======================================
--- /trunk/user/src/com/google/gwt/user/cellview/client/PagingListViewPresenter.java Thu Aug 5 10:37:27 2010 +++ /trunk/user/src/com/google/gwt/user/cellview/client/PagingListViewPresenter.java Mon Aug 9 07:41:33 2010
@@ -22,9 +22,8 @@
 import com.google.gwt.user.client.ui.Widget;
 import com.google.gwt.view.client.PagingListView;
 import com.google.gwt.view.client.Range;
+import com.google.gwt.view.client.SelectionChangeEvent;
 import com.google.gwt.view.client.SelectionModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;

 import java.util.ArrayList;
 import java.util.HashSet;
@@ -608,7 +607,7 @@
     this.selectionModel = selectionModel;
     if (selectionModel != null) {
       selectionHandler = selectionModel.addSelectionChangeHandler(
-          new SelectionChangeHandler() {
+          new SelectionChangeEvent.Handler() {
             public void onSelectionChange(SelectionChangeEvent event) {
               updateSelection();
             }
=======================================
--- /trunk/user/src/com/google/gwt/view/client/SelectionModel.java Fri Aug 6 06:29:40 2010 +++ /trunk/user/src/com/google/gwt/view/client/SelectionModel.java Mon Aug 9 07:41:33 2010
@@ -17,7 +17,6 @@

 import com.google.gwt.core.client.Scheduler;
 import com.google.gwt.core.client.Scheduler.ScheduledCommand;
-import com.google.gwt.event.shared.EventHandler;
 import com.google.gwt.event.shared.GwtEvent;
 import com.google.gwt.event.shared.HandlerManager;
 import com.google.gwt.event.shared.HandlerRegistration;
@@ -57,7 +56,7 @@
     private ProvidesKey<T> keyProvider;

     public HandlerRegistration addSelectionChangeHandler(
-        SelectionChangeHandler handler) {
+        SelectionChangeEvent.Handler handler) {
return handlerManager.addHandler(SelectionChangeEvent.getType(), handler);
     }

@@ -101,7 +100,7 @@
     }

     /**
- * Schedules a {...@link SelectionModel.SelectionChangeEvent} to fire at the
+     * Schedules a {...@link SelectionChangeEvent} to fire at the
      * end of the current event loop.
      */
     protected void scheduleSelectionChangeEvent() {
@@ -129,72 +128,6 @@
       this.isEventScheduled = isEventScheduled;
     }
   }
-
-  /**
-   * Represents a selection change event.
-   */
-  public static class SelectionChangeEvent extends
-      GwtEvent<SelectionChangeHandler> {
-
-    /**
-     * Handler type.
-     */
-    private static Type<SelectionChangeHandler> TYPE;
-
-    /**
-     * Gets the type associated with this event.
-     *
-     * @return returns the handler type
-     */
-    public static Type<SelectionChangeHandler> getType() {
-      if (TYPE == null) {
-        TYPE = new Type<SelectionChangeHandler>();
-      }
-      return TYPE;
-    }
-
-    /**
- * Fires a selection change event on all registered handlers in the handler
-     * manager. If no such handlers exist, this method will do nothing.
-     *
-     * @param source the source of the handlers
-     */
-    static void fire(SelectionModel<?> source) {
-      if (TYPE != null) {
-        SelectionChangeEvent event = new SelectionChangeEvent();
-        source.fireEvent(event);
-      }
-    }
-
-    /**
-     * Creates a selection change event.
-     */
-    SelectionChangeEvent() {
-    }
-
-    @Override
-    public final Type<SelectionChangeHandler> getAssociatedType() {
-      return TYPE;
-    }
-
-    @Override
-    protected void dispatch(SelectionChangeHandler handler) {
-      handler.onSelectionChange(this);
-    }
-  }
-
-  /**
-   * Handler interface for {...@link SelectionChangeEvent} events.
-   */
-  public interface SelectionChangeHandler extends EventHandler {
-
-    /**
-     * Called when {...@link SelectionChangeEvent} is fired.
-     *
-     * @param event the {...@link SelectionChangeEvent} that was fired
-     */
-    void onSelectionChange(SelectionChangeEvent event);
-  }

   /**
    * Adds a {...@link SelectionChangeEvent} handler.
@@ -202,7 +135,7 @@
    * @param handler the handler
    * @return the registration for the event
    */
- HandlerRegistration addSelectionChangeHandler(SelectionChangeHandler handler); + HandlerRegistration addSelectionChangeHandler(SelectionChangeEvent.Handler handler);

   /**
    * Check if an object is selected.
@@ -214,7 +147,7 @@

   /**
    * Set the selected state of an object and fire a
-   * {...@link SelectionModel.SelectionChangeEvent} if the selection has
+   * {...@link SelectionChangeEvent} if the selection has
    * changed.  Subclasses should not fire an event in the case where
    * selected is true and the object was already selected, or selected
    * is false and the object was not previously selected.
=======================================
--- /trunk/user/test/com/google/gwt/view/client/AbstractSelectionModelTest.java Fri Aug 6 06:29:40 2010 +++ /trunk/user/test/com/google/gwt/view/client/AbstractSelectionModelTest.java Mon Aug 9 07:41:33 2010
@@ -18,8 +18,6 @@
 import com.google.gwt.junit.client.GWTTestCase;
 import com.google.gwt.user.client.Timer;
 import com.google.gwt.view.client.SelectionModel.AbstractSelectionModel;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;

 /**
  * Tests for {...@link AbstractSelectionModel}.
@@ -27,10 +25,10 @@
 public class AbstractSelectionModelTest extends GWTTestCase {

   /**
-   * A mock {...@link SelectionChangeHandler} used for testing.
+   * A mock {...@link SelectionChangeEvent.Handler} used for testing.
    */
   private static class MockSelectionChangeHandler implements
-      SelectionChangeHandler {
+      SelectionChangeEvent.Handler {

     private boolean eventFired;

=======================================
--- /trunk/user/test/com/google/gwt/view/client/DefaultSelectionModelTest.java Fri Aug 6 06:29:40 2010 +++ /trunk/user/test/com/google/gwt/view/client/DefaultSelectionModelTest.java Mon Aug 9 07:41:33 2010
@@ -15,9 +15,6 @@
  */
 package com.google.gwt.view.client;

-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;
-
 import java.util.HashMap;
 import java.util.Map;

@@ -49,7 +46,7 @@

   public void testSelectedChangeEvent() {
     DefaultSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         finishTest();
       }
@@ -62,7 +59,7 @@

   public void testNoDuplicateChangeEvent() {
     DefaultSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         fail();
       }
=======================================
--- /trunk/user/test/com/google/gwt/view/client/MockPagingListView.java Fri Jul 2 09:26:53 2010 +++ /trunk/user/test/com/google/gwt/view/client/MockPagingListView.java Mon Aug 9 07:41:33 2010
@@ -16,8 +16,6 @@
 package com.google.gwt.view.client;

 import com.google.gwt.event.shared.HandlerRegistration;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;

 import java.util.List;

@@ -185,7 +183,7 @@
     // Add the new selection model.
     this.selectionModel = selectionModel;
     if (selectionModel != null) {
- selectionHandler = selectionModel.addSelectionChangeHandler(new SelectionChangeHandler() { + selectionHandler = selectionModel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() {
         public void onSelectionChange(SelectionChangeEvent event) {
         }
       });
=======================================
--- /trunk/user/test/com/google/gwt/view/client/MultiSelectionModelTest.java Fri Aug 6 06:29:40 2010 +++ /trunk/user/test/com/google/gwt/view/client/MultiSelectionModelTest.java Mon Aug 9 07:41:33 2010
@@ -15,9 +15,6 @@
  */
 package com.google.gwt.view.client;

-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;
-
 import java.util.HashSet;
 import java.util.Set;

@@ -46,7 +43,7 @@

   public void testSelectedChangeEvent() {
     MultiSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         finishTest();
       }
@@ -59,7 +56,7 @@

   public void testNoDuplicateChangeEvent() {
     MultiSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         fail();
       }
@@ -73,7 +70,7 @@

   public void testNoDuplicateChangeEvent2() {
     MultiSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         fail();
       }
=======================================
--- /trunk/user/test/com/google/gwt/view/client/NoSelectionModelTest.java Fri Jul 2 10:23:18 2010 +++ /trunk/user/test/com/google/gwt/view/client/NoSelectionModelTest.java Mon Aug 9 07:41:33 2010
@@ -15,9 +15,6 @@
  */
 package com.google.gwt.view.client;

-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;
-
 /**
  * Tests for {...@link NoSelectionModel}.
  */
@@ -36,7 +33,7 @@

   public void testSelectedChangeEvent() {
     NoSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         finishTest();
       }
=======================================
--- /trunk/user/test/com/google/gwt/view/client/SingleSelectionModelTest.java Fri Aug 6 06:29:40 2010 +++ /trunk/user/test/com/google/gwt/view/client/SingleSelectionModelTest.java Mon Aug 9 07:41:33 2010
@@ -15,9 +15,6 @@
  */
 package com.google.gwt.view.client;

-import com.google.gwt.view.client.SelectionModel.SelectionChangeEvent;
-import com.google.gwt.view.client.SelectionModel.SelectionChangeHandler;
-
 /**
  * Tests for {...@link SingleSelectionModel}.
  */
@@ -36,7 +33,7 @@

   public void testSelectedChangeEvent() {
     SingleSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         finishTest();
       }
@@ -49,7 +46,7 @@

   public void testNoDuplicateChangeEvent() {
     SingleSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         fail();
       }
@@ -63,7 +60,7 @@

   public void testNoDuplicateChangeEvent2() {
     SingleSelectionModel<String> model = createSelectionModel();
-    SelectionChangeHandler handler = new SelectionChangeHandler() {
+ SelectionChangeEvent.Handler handler = new SelectionChangeEvent.Handler() {
       public void onSelectionChange(SelectionChangeEvent event) {
         fail();
       }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to