http://gwt-code-reviews.appspot.com/717801/diff/20002/33060
File user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java
(right):

http://gwt-code-reviews.appspot.com/717801/diff/20002/33060#newcode54
user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java:54: public
ProxyListPlace go(Place place) {
Whats confusing is that it saves the record returned by
proxyPlace().getProxy(), and then I can get the record by calling
getProxy().  Its a stateful class, but I don't understand why.  Do you
ever call ProxyPlaceToListPlace.getProxy()?

http://gwt-code-reviews.appspot.com/717801/diff/20002/33062
File user/src/com/google/gwt/event/shared/EventBus.java (right):

http://gwt-code-reviews.appspot.com/717801/diff/20002/33062#newcode45
user/src/com/google/gwt/event/shared/EventBus.java:45: void
fireEvent(GwtEvent<?> event);
There are probably a lot of people using it because all HasXXXHandlers
extend it.  For example, HasClickHandlers extends it and adds
addBlurHandler.

http://gwt-code-reviews.appspot.com/717801/diff/20002/33070
File user/src/com/google/gwt/user/client/ui/HasConstrainedValue.java
(right):

http://gwt-code-reviews.appspot.com/717801/diff/20002/33070#newcode34
user/src/com/google/gwt/user/client/ui/HasConstrainedValue.java:34: void
setValues(Collection<T> values, Renderer<T> render);
Assuming you mean for ImageLoadingCell, I think the renderers had more
to do with being able to customize loading and error messages than
building safe HTML.  Either way, we'll need to take a look at how to
integrate the renderers in ImageLoadingCell with SafeHtmlBuilder,
because you can't just return an HTML string and call it unsafe.  We
might need a SafeHtmlRenderer that takes a SafeHtmlBuilder instead of
returning a String.

http://gwt-code-reviews.appspot.com/717801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to