Revision: 8520
Author: [email protected]
Date: Wed Aug 11 09:22:23 2010
Log: Add @Override tags in order to be able to enable Eclipse warnings
without being drowned
Review at http://gwt-code-reviews.appspot.com/754801
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=8520
Modified:
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldDetailsActivities.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListActivity.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsActivity.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListActivity.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/AppCacheWarmer.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Employee.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Expense.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Report.java
/trunk/dev/core/src/com/google/gwt/core/ext/TreeLogger.java
/trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JConstructor.java
/trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JField.java
/trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JMethod.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionAll.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionAny.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionNone.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenPropertyIs.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeIs.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/RuleFail.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/RuleGenerateWith.java
/trunk/dev/core/src/com/google/gwt/dev/cfg/RuleReplaceWith.java
/trunk/dev/core/src/com/google/gwt/dev/generator/ast/BaseNode.java
/trunk/dev/core/src/com/google/gwt/dev/generator/ast/Expression.java
/trunk/dev/core/src/com/google/gwt/dev/javac/JsniChecker.java
/trunk/dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
/trunk/dev/core/src/com/google/gwt/dev/jdt/FindJsniRefVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JArrayType.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JBooleanLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JDoubleLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JFloatLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JModVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNode.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNullLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPostfixOperation.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPrefixOperation.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPrimitiveType.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JStringLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JUnaryOperator.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodRef.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/AssertionNormalizer.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/JsIEBlockTextTransformer.java
/trunk/dev/core/src/com/google/gwt/dev/js/JsConstructExpressionVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/js/JsFirstExpressionVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/js/JsHoister.java
/trunk/dev/core/src/com/google/gwt/dev/js/JsRequiresSemiVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsArrayLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsBooleanLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsBreak.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsConditional.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsContinue.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsFunction.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsModVisitor.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsNullLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsNumberLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsObjectLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsRegExp.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsReturn.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsStringLiteral.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsThisRef.java
/trunk/dev/core/src/com/google/gwt/dev/js/ast/JsThrow.java
/trunk/dev/core/src/com/google/gwt/dev/shell/EmmaStrategy.java
/trunk/dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java
/trunk/dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java
/trunk/dev/core/src/com/google/gwt/dev/shell/log/ServletContextTreeLogger.java
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceTreeLogger.java
/trunk/dev/core/src/com/google/gwt/dev/shell/tomcat/CatalinaLoggerAdapter.java
/trunk/dev/core/src/com/google/gwt/dev/util/DefaultTextOutput.java
/trunk/dev/core/src/com/google/gwt/dev/util/NetProxy.java
/trunk/dev/core/src/com/google/gwt/dev/util/StringKey.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerExtraDir.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerGenDir.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerLogLevel.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerOutDir.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerScriptStyle.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerTreeLoggerFlag.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerValidateOnlyFlag.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWarDir.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWorkDirOptional.java
/trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWorkDirRequired.java
/trunk/dev/core/src/com/google/gwt/dev/util/collect/IdentitySets.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForClass.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForFile.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForInteger.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForLong.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForMethod.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForString.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForStringArray.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterForURL.java
/trunk/dev/core/src/com/google/gwt/dev/util/msg/FormatterToString.java
/trunk/dev/core/src/com/google/gwt/dev/util/xml/AttributeConverterForBoolean.java
/trunk/dev/core/src/com/google/gwt/dev/util/xml/AttributeConverterForInteger.java
/trunk/dev/core/src/com/google/gwt/dev/util/xml/AttributeConverterForString.java
/trunk/dev/core/src/com/google/gwt/dev/util/xml/DefaultSchema.java
/trunk/dev/core/src/com/google/gwt/dev/util/xml/HandlerMethod.java
/trunk/dev/core/src/com/google/gwt/dev/util/xml/ReflectiveParser.java
/trunk/dev/core/src/com/google/gwt/util/tools/ArgHandlerDir.java
/trunk/dev/core/src/com/google/gwt/util/tools/ArgHandlerExtra.java
/trunk/dev/core/src/com/google/gwt/util/tools/ArgHandlerFile.java
/trunk/dev/core/src/com/google/gwt/util/tools/ArgHandlerFlag.java
/trunk/dev/core/src/com/google/gwt/util/tools/ArgHandlerInt.java
/trunk/dev/core/src/com/google/gwt/util/tools/ArgHandlerOutDir.java
/trunk/dev/core/src/com/google/gwt/util/tools/ArgHandlerString.java
/trunk/dev/core/test/com/google/gwt/core/ext/typeinfo/JWildcardTypeTest.java
/trunk/user/src/com/google/gwt/benchmarks/client/impl/BenchmarkResults.java
/trunk/user/src/com/google/gwt/cell/client/EditTextCell.java
/trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
/trunk/user/src/com/google/gwt/dom/client/Style.java
/trunk/user/src/com/google/gwt/json/client/JSONNull.java
/trunk/user/src/com/google/gwt/junit/GWTDummyBridge.java
/trunk/user/src/com/google/gwt/logging/impl/LevelImplRegular.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/RecordKey.java
/trunk/user/src/com/google/gwt/requestfactory/server/OperationRegistry.java
/trunk/user/src/com/google/gwt/requestfactory/server/UserInformation.java
/trunk/user/src/com/google/gwt/resources/css/ClassRenamer.java
/trunk/user/src/com/google/gwt/resources/css/ast/CssSprite.java
/trunk/user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
/trunk/user/src/com/google/gwt/resources/rebind/context/InlineClientBundleGenerator.java
/trunk/user/src/com/google/gwt/resources/rebind/context/StaticClientBundleGenerator.java
/trunk/user/src/com/google/gwt/rpc/client/impl/CommandClientSerializationStreamWriter.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/BooleanAttributeParser.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/DoubleAttributeParser.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/EnumAttributeParser.java
/trunk/user/src/com/google/gwt/uibinder/attributeparsers/IntAttributeParser.java
/trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
/trunk/user/src/com/google/gwt/user/client/ui/LayoutPanel.java
/trunk/user/src/com/google/gwt/user/client/ui/ScrollPanel.java
/trunk/user/src/com/google/gwt/user/client/ui/ValueBox.java
/trunk/user/src/com/google/gwt/user/rebind/AsyncProxyGenerator.java
/trunk/user/src/com/google/gwt/view/client/DefaultSelectionModel.java
/trunk/user/src/com/google/gwt/xml/client/impl/DOMItem.java
/trunk/user/src/com/google/gwt/xml/client/impl/XMLParserImplIE6.java
/trunk/user/src/com/google/gwt/xml/client/impl/XMLParserImplStandard.java
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldDetailsActivities.java
Fri May 28 08:44:36 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldDetailsActivities.java
Wed Aug 11 09:22:23 2010
@@ -46,10 +46,12 @@
public Activity getActivity(ScaffoldPlace place) {
return place.acceptFilter(new BaseScaffoldPlaceFilter<Activity>(null) {
+ @Override
public Activity filter(EmployeeScaffoldPlace place) {
return employeeActivities.getActivity(place);
}
+ @Override
public Activity filter(ReportScaffoldPlace place) {
return reportActivities.getActivity(place);
}
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java
Tue Aug 10 18:34:06 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsActivity.java
Wed Aug 11 09:22:23 2010
@@ -98,10 +98,12 @@
Operation.EDIT));
}
+ @Override
public void onCancel() {
onStop();
}
-
+
+ @Override
public void onStop() {
display = null;
}
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java
Thu Aug 5 15:15:34 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java
Wed Aug 11 09:22:23 2010
@@ -79,6 +79,7 @@
return EmployeeRecord.class;
}
+ @Override
protected void setRequestObject(EmployeeRecord record) {
requestObject = requests.employeeRequest().persist(record);
}
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListActivity.java
Fri Jul 30 17:29:09 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListActivity.java
Wed Aug 11 09:22:23 2010
@@ -81,6 +81,7 @@
registration.removeHandler();
}
+ @Override
public void showDetails(EmployeeRecord record) {
placeController.goTo(new EmployeeScaffoldPlace(record,
Operation.DETAILS));
}
@@ -96,6 +97,7 @@
super.start(display);
}
+ @Override
protected RecordListRequest<EmployeeRecord> createRangeRequest(Range
range) {
return requests.employeeRequest().findEmployeeEntries(range.getStart(),
range.getLength());
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsActivity.java
Tue Aug 10 18:34:06 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsActivity.java
Wed Aug 11 09:22:23 2010
@@ -98,10 +98,12 @@
Operation.EDIT));
}
+ @Override
public void onCancel() {
onStop();
}
+ @Override
public void onStop() {
display = null;
}
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java
Thu Aug 5 15:15:34 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java
Wed Aug 11 09:22:23 2010
@@ -63,6 +63,7 @@
this.placeController = placeController;
}
+ @Override
protected void exit() {
placeController.goTo(new ReportScaffoldPlace(getId(),
Operation.DETAILS));
}
@@ -72,12 +73,13 @@
Receiver<ReportRecord> callback) {
requests.reportRequest().findReport(id).fire(callback);
}
-
+
@Override
protected Class getRecordClass() {
return ReportRecord.class;
}
+ @Override
protected void setRequestObject(ReportRecord record) {
requestObject = requests.reportRequest().persist(record);
}
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListActivity.java
Fri Jul 30 17:29:09 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListActivity.java
Wed Aug 11 09:22:23 2010
@@ -81,6 +81,7 @@
registration.removeHandler();
}
+ @Override
public void showDetails(ReportRecord record) {
placeController.goTo(new ReportScaffoldPlace(record,
Operation.DETAILS));
}
@@ -95,6 +96,7 @@
super.start(display);
}
+ @Override
protected RecordListRequest<ReportRecord> createRangeRequest(Range
range) {
return requests.reportRequest().findReportEntries(range.getStart(),
range.getLength());
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/AppCacheWarmer.java
Mon Jun 7 12:20:31 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/AppCacheWarmer.java
Wed Aug 11 09:22:23 2010
@@ -145,6 +145,7 @@
this.parameters = parameters;
}
+ @Override
public String toString() {
String returnStr = "[" + operation;
returnStr += "{";
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Employee.java
Fri May 28 08:44:36 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Employee.java
Wed Aug 11 09:22:23 2010
@@ -213,6 +213,7 @@
this.version = version;
}
+ @Override
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("Id: ").append(getId()).append(", ");
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Expense.java
Mon Jun 7 12:20:31 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Expense.java
Wed Aug 11 09:22:23 2010
@@ -206,6 +206,7 @@
this.version = version;
}
+ @Override
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("Id: ").append(getId()).append(", ");
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
Wed Aug 4 14:25:37 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java
Wed Aug 11 09:22:23 2010
@@ -36,6 +36,7 @@
super(redirectUrl);
}
+ @Override
public String getEmail() {
User user = userService.getCurrentUser();
if (user == null) {
@@ -44,6 +45,7 @@
return user.getEmail();
}
+ @Override
public Long getId() {
User user = userService.getCurrentUser();
if (user == null) {
@@ -52,14 +54,17 @@
return new Long(user.hashCode());
}
+ @Override
public String getLoginUrl() {
return userService.createLoginURL(redirectUrl);
}
+ @Override
public String getLogoutUrl() {
return userService.createLogoutURL(redirectUrl);
}
+ @Override
public String getName() {
User user = userService.getCurrentUser();
if (user == null) {
@@ -68,6 +73,7 @@
return user.getNickname();
}
+ @Override
public boolean isUserLoggedIn() {
return userService.isUserLoggedIn();
}
@@ -76,6 +82,7 @@
* Does nothing since in GAE authentication, the unique ID is provided by
* the user service and is based on a hash in the User object.
*/
+ @Override
public void setId(Long id) {
// Do nothing
}
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Report.java
Mon Jun 7 12:20:31 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain/Report.java
Wed Aug 11 09:22:23 2010
@@ -453,6 +453,7 @@
this.version = version;
}
+ @Override
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("Id: ").append(getId()).append(", ");
=======================================
--- /trunk/dev/core/src/com/google/gwt/core/ext/TreeLogger.java Thu Nov 5
08:35:05 2009
+++ /trunk/dev/core/src/com/google/gwt/core/ext/TreeLogger.java Wed Aug 11
09:22:23 2010
@@ -192,6 +192,7 @@
return this;
}
+ @Override
public boolean isLoggable(Type type) {
return false;
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JConstructor.java
Mon Jun 22 07:10:10 2009
+++ /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JConstructor.java
Wed Aug 11 09:22:23 2010
@@ -47,6 +47,7 @@
return enclosingType;
}
+ @Override
public String getJsniSignature() {
StringBuilder sb = new StringBuilder("@");
sb.append(getEnclosingType().getQualifiedSourceName());
=======================================
--- /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JField.java Wed
Apr 1 13:03:34 2009
+++ /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JField.java Wed
Aug 11 09:22:23 2010
@@ -136,6 +136,7 @@
this.type = type;
}
+ @Override
public String toString() {
String[] names = TypeOracle.modifierBitsToNames(modifierBits);
StringBuffer sb = new StringBuffer();
=======================================
--- /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JMethod.java Mon
Jun 22 07:10:10 2009
+++ /trunk/dev/core/src/com/google/gwt/core/ext/typeinfo/JMethod.java Wed
Aug 11 09:22:23 2010
@@ -50,6 +50,7 @@
return enclosingType;
}
+ @Override
public String getJsniSignature() {
StringBuilder sb = new StringBuilder("@");
sb.append(getEnclosingType().getQualifiedSourceName());
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionAll.java Thu Mar 4
12:16:00 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionAll.java Wed Aug 11
09:22:23 2010
@@ -29,6 +29,7 @@
public ConditionAll() {
}
+ @Override
protected boolean doEval(TreeLogger logger, DeferredBindingQuery query)
throws UnableToCompleteException {
for (Iterator<Condition> iter = getConditions().iterator();
iter.hasNext();) {
@@ -40,6 +41,7 @@
return true;
}
+ @Override
protected String getEvalAfterMessage(String testType, boolean result) {
if (result) {
return "Yes: All subconditions were true";
@@ -48,6 +50,7 @@
}
}
+ @Override
protected String getEvalBeforeMessage(String testType) {
return "Checking if all subconditions are true (<all>)";
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionAny.java Thu Mar 4
12:16:00 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionAny.java Wed Aug 11
09:22:23 2010
@@ -28,6 +28,7 @@
public ConditionAny() {
}
+ @Override
protected boolean doEval(TreeLogger logger, DeferredBindingQuery query)
throws UnableToCompleteException {
for (Iterator<Condition> iter = getConditions().iterator();
iter.hasNext();) {
@@ -39,6 +40,7 @@
return false;
}
+ @Override
protected String getEvalAfterMessage(String testType, boolean result) {
if (result) {
return "Yes: One or more subconditions was true";
@@ -47,6 +49,7 @@
}
}
+ @Override
protected String getEvalBeforeMessage(String testType) {
return "Checking if any subcondition is true (<any>)";
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionNone.java Thu Mar
4 12:16:00 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionNone.java Wed Aug
11 09:22:23 2010
@@ -29,6 +29,7 @@
public ConditionNone() {
}
+ @Override
protected boolean doEval(TreeLogger logger, DeferredBindingQuery query)
throws UnableToCompleteException {
for (Iterator<Condition> iter = getConditions().iterator();
iter.hasNext();) {
@@ -40,6 +41,7 @@
return true;
}
+ @Override
protected String getEvalAfterMessage(String testType, boolean result) {
if (result) {
return "Yes: All subconditions were false";
@@ -48,6 +50,7 @@
}
}
+ @Override
protected String getEvalBeforeMessage(String testType) {
return "Checking if all subconditions are false (<none>)";
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenPropertyIs.java
Thu Mar 4 12:16:00 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenPropertyIs.java
Wed Aug 11 09:22:23 2010
@@ -45,10 +45,12 @@
return Sets.create(propName);
}
+ @Override
public String toString() {
return "<when-property-is name='" + propName + "' value='" + value
+ "'/>";
}
+ @Override
protected boolean doEval(TreeLogger logger, DeferredBindingQuery query)
throws UnableToCompleteException {
PropertyOracle propertyOracle = query.getPropertyOracle();
@@ -76,6 +78,7 @@
}
}
+ @Override
protected String getEvalAfterMessage(String testType, boolean result) {
if (result) {
return "Yes, the property value matched";
@@ -84,6 +87,7 @@
}
}
+ @Override
protected String getEvalBeforeMessage(String testType) {
return toString();
}
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java
Thu Mar 4 12:16:00 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java
Wed Aug 11 09:22:23 2010
@@ -37,10 +37,12 @@
return assignableToTypeName;
}
+ @Override
public String toString() {
return "<when-assignable class='" + assignableToTypeName + "'/>";
}
+ @Override
protected boolean doEval(TreeLogger logger, DeferredBindingQuery query)
throws UnableToCompleteException {
TypeOracle typeOracle = query.getTypeOracle();
@@ -69,6 +71,7 @@
}
}
+ @Override
protected String getEvalAfterMessage(String testType, boolean result) {
if (result) {
return "Yes, the requested type was assignable";
@@ -77,6 +80,7 @@
}
}
+ @Override
protected String getEvalBeforeMessage(String testType) {
return toString();
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeIs.java Thu
Mar 4 12:16:00 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeIs.java Wed
Aug 11 09:22:23 2010
@@ -29,14 +29,17 @@
this.exactTypeName = exactTypeName;
}
+ @Override
public String toString() {
return "<when-type-is class='" + exactTypeName + "'/>";
}
+ @Override
protected boolean doEval(TreeLogger logger, DeferredBindingQuery query) {
return exactTypeName.equals(query.getTestType());
}
+ @Override
protected String getEvalAfterMessage(String testType, boolean result) {
if (result) {
return "Yes, the requested type was an exact match";
@@ -45,6 +48,7 @@
}
}
+ @Override
protected String getEvalBeforeMessage(String testType) {
return toString();
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/RuleFail.java Tue Nov 10
08:44:05 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/RuleFail.java Wed Aug 11
09:22:23 2010
@@ -24,6 +24,7 @@
*/
public class RuleFail extends Rule {
+ @Override
public String realize(TreeLogger logger, StandardGeneratorContext
context,
String typeName) throws UnableToCompleteException {
logger.log(TreeLogger.ERROR, "Deferred binding request failed for
type '"
@@ -31,8 +32,8 @@
throw new UnableToCompleteException();
}
+ @Override
public String toString() {
return "<fail>";
}
-
-}
+}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/RuleGenerateWith.java Tue
Nov 10 08:44:05 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/RuleGenerateWith.java Wed
Aug 11 09:22:23 2010
@@ -33,11 +33,13 @@
this.generatorClass = generatorClass;
}
+ @Override
public String realize(TreeLogger logger, StandardGeneratorContext
context,
String typeName) throws UnableToCompleteException {
return context.runGenerator(logger, generatorClass, typeName);
}
+ @Override
public String toString() {
return "<generate-with class='" + generatorClass.getName() + "'/>";
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/cfg/RuleReplaceWith.java Tue Nov
10 08:44:05 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/cfg/RuleReplaceWith.java Wed Aug
11 09:22:23 2010
@@ -34,11 +34,13 @@
return replacementTypeName;
}
+ @Override
public String realize(TreeLogger logger, StandardGeneratorContext
context,
String typeName) throws UnableToCompleteException {
return replacementTypeName;
}
+ @Override
public String toString() {
return "<replace-with class='" + replacementTypeName + "'/>";
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/generator/ast/BaseNode.java Fri
May 25 09:38:51 2007
+++ /trunk/dev/core/src/com/google/gwt/dev/generator/ast/BaseNode.java Wed
Aug 11 09:22:23 2010
@@ -22,6 +22,7 @@
public abstract String toCode();
+ @Override
public String toString() {
return toCode();
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/generator/ast/Expression.java
Fri May 25 09:38:51 2007
+++ /trunk/dev/core/src/com/google/gwt/dev/generator/ast/Expression.java
Wed Aug 11 09:22:23 2010
@@ -35,6 +35,7 @@
this.code = code;
}
+ @Override
public String toCode() {
return code;
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/javac/JsniChecker.java Fri Jul
9 10:56:34 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/javac/JsniChecker.java Wed Aug
11 09:22:23 2010
@@ -100,15 +100,18 @@
suppressWarningsStack.pop();
}
+ @Override
public void endVisit(TypeDeclaration typeDeclaration, ClassScope
scope) {
suppressWarningsStack.pop();
}
+ @Override
public void endVisit(TypeDeclaration typeDeclaration,
CompilationUnitScope scope) {
suppressWarningsStack.pop();
}
+ @Override
public void endVisitValid(TypeDeclaration typeDeclaration, BlockScope
scope) {
suppressWarningsStack.pop();
}
@@ -125,12 +128,14 @@
return true;
}
+ @Override
public boolean visit(TypeDeclaration typeDeclaration,
CompilationUnitScope scope) {
suppressWarningsStack.push(getSuppressedWarnings(typeDeclaration.annotations));
return true;
}
+ @Override
public boolean visitValid(TypeDeclaration typeDeclaration, BlockScope
scope) {
suppressWarningsStack.push(getSuppressedWarnings(typeDeclaration.annotations));
return true;
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
Fri Aug 6 12:01:02 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
Wed Aug 11 09:22:23 2010
@@ -152,6 +152,7 @@
this.file = file;
}
+ @Override
public void commit() {
super.commit();
FileOutputStream fos = null;
@@ -166,6 +167,7 @@
}
}
+ @Override
public String optionalFileLocation() {
return file.getAbsolutePath();
}
@@ -197,6 +199,7 @@
return result;
}
+ @Override
public void write(byte[] b) throws IOException {
if (baos == null) {
throw new IOException("stream closed");
@@ -204,6 +207,7 @@
baos.write(b);
}
+ @Override
public void write(byte[] b, int off, int len) throws IOException {
if (baos == null) {
throw new IOException("stream closed");
@@ -211,6 +215,7 @@
baos.write(b, off, len);
}
+ @Override
public void write(int b) throws IOException {
if (baos == null) {
throw new IOException("stream closed");
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jdt/FindJsniRefVisitor.java Fri
Jul 9 10:56:34 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jdt/FindJsniRefVisitor.java Wed
Aug 11 09:22:23 2010
@@ -51,6 +51,7 @@
return Collections.unmodifiableSet(jsniRefs);
}
+ @Override
public boolean visit(MethodDeclaration methodDeclaration, ClassScope
scope) {
if (!methodDeclaration.isNative()) {
return false;
@@ -94,6 +95,7 @@
List<JsStatement> result = JsParser.parse(SourceOrigin.UNKNOWN,
jsProgram.getScope(), sr);
new JsVisitor() {
+ @Override
public void endVisit(JsNameRef x, JsContext<JsExpression> ctx) {
String ident = x.getIdent();
if (ident.charAt(0) == '@') {
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JArrayType.java Mon Jun
14 14:39:55 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JArrayType.java Wed Aug
11 09:22:23 2010
@@ -56,6 +56,7 @@
return elementType;
}
+ @Override
public String getJavahSignatureName() {
String s = leafType.getJavahSignatureName();
for (int i = 0; i < dims; ++i) {
@@ -64,6 +65,7 @@
return s;
}
+ @Override
public String getJsniSignatureName() {
String s = leafType.getJsniSignatureName();
for (int i = 0; i < dims; ++i) {
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JBooleanLiteral.java Tue
Mar 9 10:54:56 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JBooleanLiteral.java Wed
Aug 11 09:22:23 2010
@@ -53,6 +53,7 @@
return value;
}
+ @Override
public Object getValueObj() {
return Boolean.valueOf(value);
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JDoubleLiteral.java Thu
Apr 9 08:41:34 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JDoubleLiteral.java Wed
Aug 11 09:22:23 2010
@@ -67,6 +67,7 @@
return value;
}
+ @Override
public Object getValueObj() {
return new Double(value);
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JFloatLiteral.java Thu
Apr 9 08:41:34 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JFloatLiteral.java Wed
Aug 11 09:22:23 2010
@@ -67,6 +67,7 @@
return value;
}
+ @Override
public Object getValueObj() {
return new Float(value);
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JModVisitor.java Thu
Jul 8 09:38:20 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JModVisitor.java Wed Aug
11 09:22:23 2010
@@ -318,6 +318,7 @@
}
}
+ @Override
public JExpression acceptLvalue(JExpression expr) {
LvalueContext ctx = new LvalueContext();
try {
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNode.java Thu Apr 9
08:41:34 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNode.java Wed Aug 11
09:22:23 2010
@@ -48,6 +48,7 @@
}
// Causes source generation to delegate to the one visitor
+ @Override
public final String toString() {
DefaultTextOutput out = new DefaultTextOutput(false);
ToStringGenerationVisitor v = new ToStringGenerationVisitor(out);
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNullLiteral.java Tue
Mar 9 10:54:56 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNullLiteral.java Wed
Aug 11 09:22:23 2010
@@ -40,6 +40,7 @@
return JNullType.INSTANCE;
}
+ @Override
public Object getValueObj() {
return null;
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPostfixOperation.java
Thu Apr 9 08:41:34 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPostfixOperation.java
Wed Aug 11 09:22:23 2010
@@ -26,11 +26,11 @@
super(info, op, arg);
}
+ @Override
public void traverse(JVisitor visitor, Context ctx) {
if (visitor.visit(this, ctx)) {
super.traverse(visitor, ctx);
}
visitor.endVisit(this, ctx);
}
-
-}
+}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPrefixOperation.java
Thu Apr 9 08:41:34 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPrefixOperation.java
Wed Aug 11 09:22:23 2010
@@ -26,11 +26,11 @@
super(info, op, arg);
}
+ @Override
public void traverse(JVisitor visitor, Context ctx) {
if (visitor.visit(this, ctx)) {
super.traverse(visitor, ctx);
}
visitor.endVisit(this, ctx);
}
-
-}
+}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPrimitiveType.java Thu
Apr 9 08:41:34 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JPrimitiveType.java Wed
Aug 11 09:22:23 2010
@@ -86,10 +86,12 @@
return "Class.createForPrimitive";
}
+ @Override
public String getJavahSignatureName() {
return signatureName;
}
+ @Override
public String getJsniSignatureName() {
return signatureName;
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JStringLiteral.java Fri
Apr 2 14:35:01 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JStringLiteral.java Wed
Aug 11 09:22:23 2010
@@ -47,6 +47,7 @@
return value;
}
+ @Override
public Object getValueObj() {
return value;
}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JUnaryOperator.java Tue
Mar 18 19:17:40 2008
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JUnaryOperator.java Wed
Aug 11 09:22:23 2010
@@ -36,8 +36,8 @@
return this == INC || this == DEC;
}
+ @Override
public String toString() {
return new String(getSymbol());
}
-
-}
+}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodRef.java
Thu Apr 9 08:41:34 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodRef.java
Wed Aug 11 09:22:23 2010
@@ -54,6 +54,7 @@
return false;
}
+ @Override
public void traverse(JVisitor visitor, Context ctx) {
if (visitor.visit(this, ctx)) {
}
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/AssertionNormalizer.java
Fri Aug 6 12:01:02 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/AssertionNormalizer.java
Wed Aug 11 09:22:23 2010
@@ -41,6 +41,7 @@
*/
private class AssertNormalizeVisitor extends JModVisitor {
+ @Override
public void endVisit(JAssertStatement x, Context ctx) {
JExpression lhs = x.getTestExpr();
String methodName = "Exceptions.throwAssertionError"
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
Wed Jul 21 05:01:19 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
Wed Aug 11 09:22:23 2010
@@ -1343,6 +1343,7 @@
*/
private JsNameRef dontReplaceCtor;
+ @Override
public void endVisit(JsInvocation x, JsContext<JsExpression> ctx) {
// Replace invocation to ctor with a new op.
if (x.getQualifier() instanceof JsNameRef) {
@@ -1424,6 +1425,7 @@
}
}
+ @Override
public boolean visit(JsInvocation x, JsContext<JsExpression> ctx) {
if (x.getQualifier() instanceof JsNameRef) {
dontReplaceCtor = (JsNameRef) x.getQualifier();
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
Mon Mar 29 05:13:55 2010
+++
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
Wed Aug 11 09:22:23 2010
@@ -55,6 +55,7 @@
super(js, statementRanges);
}
+ @Override
public void exec() {
functionIndices = new LinkedList<Integer>();
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/JsIEBlockTextTransformer.java
Wed Oct 28 09:10:53 2009
+++
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/JsIEBlockTextTransformer.java
Wed Aug 11 09:22:23 2010
@@ -44,6 +44,7 @@
/**
* Do not perform clustering, only fix up IE7 block issue.
*/
+ @Override
public void exec() {
doSplits = statementRanges.numStatements() > MAX_BLOCK_SIZE;
if (doSplits) {
@@ -58,6 +59,7 @@
/**
* Record start of statement, and optionally inject new open block.
*/
+ @Override
protected void beginStatement(StringBuilder newJs,
ArrayList<Integer> starts) {
if (doSplits && currentStatementCount == 0) {
@@ -79,6 +81,7 @@
* Record end of statement, and optionally inject close block, if block
is
* full.
*/
+ @Override
protected void endStatement(StringBuilder newJs, ArrayList<Integer>
ends) {
currentStatementCount++;
if (doSplits && currentStatementCount == MAX_BLOCK_SIZE) {
=======================================
---
/trunk/dev/core/src/com/google/gwt/dev/js/JsConstructExpressionVisitor.java
Mon Oct 26 14:02:26 2009
+++
/trunk/dev/core/src/com/google/gwt/dev/js/JsConstructExpressionVisitor.java
Wed Aug 11 09:22:23 2010
@@ -106,6 +106,7 @@
* We only look at nodes that would not normally be surrounded by
parentheses.
*/
@SuppressWarnings("cast")
+ @Override
protected <T extends JsVisitable<T>> T doAccept(T node) {
/*
* Extra casts to Object to prevent 'inconvertible types' compile
errors due
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/js/JsFirstExpressionVisitor.java
Tue Nov 6 15:20:08 2007
+++ /trunk/dev/core/src/com/google/gwt/dev/js/JsFirstExpressionVisitor.java
Wed Aug 11 09:22:23 2010
@@ -73,35 +73,42 @@
private JsFirstExpressionVisitor() {
}
+ @Override
public boolean visit(JsArrayAccess x, JsContext<JsExpression> ctx) {
accept(x.getArrayExpr());
return false;
}
+ @Override
public boolean visit(JsArrayLiteral x, JsContext<JsExpression> ctx) {
return false;
}
+ @Override
public boolean visit(JsBinaryOperation x, JsContext<JsExpression> ctx) {
accept(x.getArg1());
return false;
}
+ @Override
public boolean visit(JsConditional x, JsContext<JsExpression> ctx) {
accept(x.getTestExpression());
return false;
}
+ @Override
public boolean visit(JsFunction x, JsContext<JsExpression> ctx) {
needsParentheses = true;
return false;
}
+ @Override
public boolean visit(JsInvocation x, JsContext<JsExpression> ctx) {
accept(x.getQualifier());
return false;
}
+ @Override
public boolean visit(JsNameRef x, JsContext<JsExpression> ctx) {
if (!x.isLeaf()) {
accept(x.getQualifier());
@@ -109,26 +116,30 @@
return false;
}
+ @Override
public boolean visit(JsNew x, JsContext<JsExpression> ctx) {
return false;
}
+ @Override
public boolean visit(JsObjectLiteral x, JsContext<JsExpression> ctx) {
needsParentheses = true;
return false;
}
+ @Override
public boolean visit(JsPostfixOperation x, JsContext<JsExpression> ctx) {
accept(x.getArg());
return false;
}
+ @Override
public boolean visit(JsPrefixOperation x, JsContext<JsExpression> ctx) {
return false;
}
+ @Override
public boolean visit(JsRegExp x, JsContext<JsExpression> ctx) {
return false;
}
-
-}
+}
=======================================
--- /trunk/dev/core/src/com/google/gwt/dev/js/JsHoister.java Tue Mar 23
14:56:21 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/js/JsHoister.java Wed Aug 11
09:22:23 2010
@@ -130,6 +130,7 @@
stack.push(toReturn);
}
+ @Override
public void endVisit(JsNameOf x, JsContext<JsExpression> ctx) {
JsNameOf toReturn = new JsNameOf(x.getSourceInfo(), x.getName());
stack.push(toReturn);
=======================================
***Additional files exist in this changeset.***
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
