Submitted r8526

On 2010/08/12 17:35:02, Ray Ryan wrote:
Oops, missed some of your questions.

Applying the fixes and submitting.

http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File

samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):

http://gwt-code-reviews.appspot.com/755801/diff/5001/6002#newcode50

samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java:50:

On 2010/08/12 13:48:12, bobv wrote:
> Extra whitespace.  I remember having to mess with my checkstyle
settings to
> convince eclipse it wanted to check stuff in the dynatablerf sample.

Done.

http://gwt-code-reviews.appspot.com/755801/diff/5001/6002#newcode78

samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java:78:
if (response.size() > 0) {
Yes, if I understood your question.

This is just a hack, an arbitrary trigger to find an arbitrary object
to mess
with to show you how it's done. I can't imagine actually doing the
actual if
check, I only put it there in case you managed to scroll off the end
of the
table. And it fails at that, because I'm messing with 1, not zero.
Duh. Fixing.



http://gwt-code-reviews.appspot.com/755801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to