Mostly LGTM. Several formatting nits, and one question about the JType ctor.
http://gwt-code-reviews.appspot.com/748802/diff/1/3 File dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java (right): http://gwt-code-reviews.appspot.com/748802/diff/1/3#newcode270 dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java:270: realParameterNames = getEnclosingType().getOracle().getJavaSourceParser().getArguments( Not sure about the formatting here - it is over 80 chars anyway, and breaks at a really horrible place. I would suggest keeping it all on one line or breaking at the previous (). http://gwt-code-reviews.appspot.com/748802/diff/1/6 File dev/core/src/com/google/gwt/core/ext/typeinfo/JArrayType.java (right): http://gwt-code-reviews.appspot.com/748802/diff/1/6#newcode199 dev/core/src/com/google/gwt/core/ext/typeinfo/JArrayType.java:199: Why add spaces here? http://gwt-code-reviews.appspot.com/748802/diff/1/17 File dev/core/src/com/google/gwt/core/ext/typeinfo/JParameterizedType.java (right): http://gwt-code-reviews.appspot.com/748802/diff/1/17#newcode102 dev/core/src/com/google/gwt/core/ext/typeinfo/JParameterizedType.java:102: assert (this.typeArgs.indexOf(null) == -1) : "Unresolved typeArg creating JParameterizedType from " The previous formatting seems better -- this breaks awkwardly and exceeds 80 characters. http://gwt-code-reviews.appspot.com/748802/diff/1/20 File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right): http://gwt-code-reviews.appspot.com/748802/diff/1/20#newcode23 dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:23: JType() { Why is this needed? It can't be instantiated directly anyway. http://gwt-code-reviews.appspot.com/748802/diff/1/26 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/748802/diff/1/26#newcode204 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:204: * Why did you add blanks at the end of many comment lines? http://gwt-code-reviews.appspot.com/748802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
