LGTM
http://gwt-code-reviews.appspot.com/741801/diff/6001/7001 File bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java (right): http://gwt-code-reviews.appspot.com/741801/diff/6001/7001#newcode110 bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java:110: new AuthenticationFailureHandler()); Wow, what a mess. LGTM, I'll clean it up later. On 2010/08/12 21:43:08, cromwellian wrote:
Because the ExpensesMobileShell and related classes had been passing
long ids
around everywhere, but there are some synchronous parts of the code
that would
expect to call record.setSupervisorKey(employeeId), which now need to
be
record.setSupervisor(employee)
I didn't see an easy way of fixing this quickly, except constructing a ExpensesMobileShell around a record object itself. On 2010/08/12 21:29:14, Ray Ryan wrote: > Holy encapsulation violation, what's going on here? Why does the
entry point
> have anything to do with firing this request, and why are you
delaying
building > the UI?
http://gwt-code-reviews.appspot.com/741801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
