Appears I spoke too soon, getting a submit-queue test failure.... On Fri, Aug 13, 2010 at 12:06 PM, <jbrosenb...@google.com> wrote: > Ok, I've addressed Bob's minor "nits" there (thanks Bob for catching)... > > I shall proceed to submit this puppy. > > Thanks for the great review guys.... > > Jason > > > http://gwt-code-reviews.appspot.com/750801/diff/10002/45012 > File user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java > (right): > > http://gwt-code-reviews.appspot.com/750801/diff/10002/45012#newcode24 > user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java:24: * > On 2010/08/13 13:35:00, bobv wrote: >> >> Add a period and delete the blank line. > > Done. > > http://gwt-code-reviews.appspot.com/750801/diff/10002/45012#newcode28 > user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java:28: final > CastableTypeMap castableTypeMap; > On 2010/08/13 13:35:00, bobv wrote: >> >> Just make this private final String js = castatableTypeMay.toJs(). > >> That way, the CTM doesn't become part of the CTDI's serialization > > stream. > > Done. > > http://gwt-code-reviews.appspot.com/750801/show >
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors
