I only quickly read through the list of added files and some of the
files' content, but I can say I really like it the way it is (with
PlaceTokenizer instead of the static fromToken method described in the
Wave)

There's a nit though, which should be probably fixed rather sooner than
later ;-)


http://gwt-code-reviews.appspot.com/717801/diff/53001/54050
File user/src/com/google/gwt/app/place/PlaceChangeRequesteEvent.java
(right):

http://gwt-code-reviews.appspot.com/717801/diff/53001/54050#newcode31
user/src/com/google/gwt/app/place/PlaceChangeRequesteEvent.java:31:
public class PlaceChangeRequesteEvent extends
This must be a typo: "Requeste" ?

http://gwt-code-reviews.appspot.com/717801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to