On 2010/08/16 18:03:23, bobv wrote:
Kevin, thanks for looking at this. Are there any other CSS testing
use-cases
that you can think of that the DebugInfo API should support?
http://gwt-code-reviews.appspot.com/770801/diff/1/5
File
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java
(right):
http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode32
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:32:
private static final CssResourceObserver IMPL =
GWT.create(CssResourceObserver.class);
> This way there's effectively only one observer instance allowed?
> I think Observer implies 1-N.
It's a singleton observer the way it's written, but if the developer
really
cares, a fan-out version could be installed.
http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode68
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:68:
private native JavaScriptObject ensureMap() /*-{
> Do we have to use JSNI?
Yes. The couple of requests that I've seen for the global map have a
use-case
where a white-box Selenium test would like to be able to determine the
obfuscated name for a class selector when inspecting the DOM.
http://gwt-code-reviews.appspot.com/770801/diff/1/6
File user/src/com/google/gwt/resources/css/ClassRenamer.java (right):
http://gwt-code-reviews.appspot.com/770801/diff/1/6#newcode138
user/src/com/google/gwt/resources/css/ClassRenamer.java:138:
sheet.getDebugInfo().addToClassMap(sourceClassName, sourceClassName);
It is a builder and should probably be named something like
DebugInfoModel.
I knew you needed input for the API, but I don't have any comments based
on my limited experience. I see you've collected some useful feedback
from users' requests, and I think it's good for version 1.
http://gwt-code-reviews.appspot.com/770801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
