Is there anything else left to do on this change? Alex's internship is
over, but we'd like to get the change in.
On 2010/08/10 08:44:14, zundel wrote:
Hi Andre, I'm waiting on Ray C or Lex to give the LGTM, but I noticed
this last patch you uploaded left out the editdistance library files.
On Mon, Aug 9, 2010 at 4:48 PM, <mailto:[email protected]>
wrote:
>
> http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
> File
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
> (right):
>
>
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43
>
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43:
> Pattern.compile("function |[_a-zA-Z$][.$_a-zA-Z0-9]*=function");
> On 2010/08/06 02:12:25, cromwellian wrote:
>
>> This regex will incorrect match vtable declarations of the form:
>
>> _.name = function() { ... }
>
>> These prototype declarations cannot be re-ordered, so don't let it
>
> match a
>>
>> single '_' symbol.
>
>
> Fixed.
>
> http://gwt-code-reviews.appspot.com/669801/show
>
--
Eric Z. Ayers
Google Web Toolkit, Atlanta, GA USA
http://gwt-code-reviews.appspot.com/669801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
