http://gwt-code-reviews.appspot.com/771801/diff/1/10
File user/src/com/google/gwt/safehtml/shared/EscapeUtils.java (right):

http://gwt-code-reviews.appspot.com/771801/diff/1/10#newcode29
user/src/com/google/gwt/safehtml/shared/EscapeUtils.java:29: * Returns a
SafeHtml constructed from a safe string, i.e. without escaping
This method's doc should stipulate the same constraints on its argument
as does SafeHtmlBuilder#appendHtmlConstant(String).

http://gwt-code-reviews.appspot.com/771801/diff/1/14
File user/src/com/google/gwt/safehtml/shared/SafeHtmlBuilder.java
(right):

http://gwt-code-reviews.appspot.com/771801/diff/1/14#newcode116
user/src/com/google/gwt/safehtml/shared/SafeHtmlBuilder.java:116: *
Boolean and numeric types converted to String are always HTML safe -- no
This comment should go above all the append(boolean/numeric type)
methods (I think methods got reordered)?

http://gwt-code-reviews.appspot.com/771801/diff/1/28
File user/test/com/google/gwt/safehtml/shared/SafeHtmlBuilderTest.java
(right):

http://gwt-code-reviews.appspot.com/771801/diff/1/28#newcode41
user/test/com/google/gwt/safehtml/shared/SafeHtmlBuilderTest.java:41:
new SafeHtmlBuilder().appendHtmlConstant("Yabba dabba &
doo\n").appendEscaped("What's up so&so\n").append(html);
Line length?

http://gwt-code-reviews.appspot.com/771801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to