[gwt-contrib] [google-web-toolkit] r8563 committed - Wrap primitive non-record types in same JSON wrapper used for Records...

Wed, 18 Aug 2010 11:44:17 -0700 

Revision: 8563
Author: [email protected]
Date: Wed Aug 18 08:38:13 2010
Log: Wrap primitive non-record types in same JSON wrapper used for Records

Review at http://gwt-code-reviews.appspot.com/777801

http://code.google.com/p/google-web-toolkit/source/detail?r=8563

Added:
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractPrimitiveRequest.java 
Modified:
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigDecimalRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigIntegerRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBooleanRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractByteRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractCharacterRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDateRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractEnumRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractFloatRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractShortRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractVoidRequest.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java /trunk/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java /trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java 
 /trunk/user/src/com/google/gwt/requestfactory/shared/RequestData.java
 /trunk/user/src/com/google/gwt/requestfactory/shared/RequestObject.java

=======================================
--- /dev/null
+++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractPrimitiveRequest.java Wed Aug 18 08:38:13 2010 
@@ -0,0 +1,44 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of 
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT 
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under 
+ * the License.
+ */
+package com.google.gwt.requestfactory.client.impl;
+
+import com.google.gwt.core.client.JavaScriptObject;
+
+/**
+ * <p>
+ * <span style="color:red">Experimental API: This class is still under rapid 
+ * development, and is very likely to be deleted. Use it at your own risk.
+ * </span>
+ * </p>
+ * Abstract implementation of
+ * {...@link com.google.gwt.requestfactory.shared.RequestFactory.RequestObject
+ * RequestFactory.RequestObject} for requests that return non-record types.
+ * @param <T> return type
+ * @param <R> type of this request object
+ */
+public abstract class AbstractPrimitiveRequest<T, R extends AbstractRequest<T, R>> extends 
+    AbstractRequest<T, R> {
+
+  public AbstractPrimitiveRequest(RequestFactoryJsonImpl requestFactory) {
+    super(requestFactory);
+  }
+
+  public void handleJsonResult(JavaScriptObject result) {
+    handlePrimitiveResult(asString(result));
+  }
+
+  protected abstract void handlePrimitiveResult(String responseText);
+}
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigDecimalRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigDecimalRequest.java Wed Aug 18 08:38:13 2010 
@@ -31,14 +31,14 @@
  * RequestFactory.RequestObject} for requests that return BigDecimal.
  */
 public abstract class AbstractBigDecimalRequest extends
-    AbstractRequest<BigDecimal, AbstractBigDecimalRequest> {
+    AbstractPrimitiveRequest<BigDecimal, AbstractBigDecimalRequest> {

   public AbstractBigDecimalRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
-    receiver.onSuccess(new BigDecimal(responseText),
+  public void handlePrimitiveResult(String responseText) {
+    receiver.onSuccess(new BigDecimal(responseText),
         Collections.<SyncResult> emptySet());
   }

=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigIntegerRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigIntegerRequest.java Wed Aug 18 08:38:13 2010 
@@ -32,13 +32,13 @@
  * RequestFactory.RequestObject} for requests that return BigInteger.
  */
 public abstract class AbstractBigIntegerRequest extends
-    AbstractRequest<BigInteger, AbstractBigIntegerRequest> {
+    AbstractPrimitiveRequest<BigInteger, AbstractBigIntegerRequest> {

   public AbstractBigIntegerRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(new BigDecimal(responseText).toBigInteger(),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBooleanRequest.java Wed Aug 4 22:08:44 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBooleanRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Boolean.
  */
 public abstract class AbstractBooleanRequest extends
-    AbstractRequest<Boolean, AbstractBooleanRequest> {
+    AbstractPrimitiveRequest<Boolean, AbstractBooleanRequest> {

   public AbstractBooleanRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(Boolean.valueOf(responseText),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractByteRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractByteRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Byte.
  */
 public abstract class AbstractByteRequest extends
-    AbstractRequest<Byte, AbstractByteRequest> {
+    AbstractPrimitiveRequest<Byte, AbstractByteRequest> {

   public AbstractByteRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(Integer.valueOf(responseText).byteValue(),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractCharacterRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractCharacterRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Character.
  */
 public abstract class AbstractCharacterRequest extends
-    AbstractRequest<Character, AbstractCharacterRequest> {
+    AbstractPrimitiveRequest<Character, AbstractCharacterRequest> {

   public AbstractCharacterRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(responseText.charAt(0),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDateRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDateRequest.java Wed Aug 18 08:38:13 2010 
@@ -31,13 +31,13 @@
  * RequestFactory.RequestObject} for requests that return Date.
  */
 public abstract class AbstractDateRequest extends
-    AbstractRequest<Date, AbstractDateRequest> {
+    AbstractPrimitiveRequest<Date, AbstractDateRequest> {

   public AbstractDateRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(new Date(Long.valueOf(responseText)),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java Fri Jul 30 11:32:15 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Double.
  */
 public abstract class AbstractDoubleRequest extends
-    AbstractRequest<Double, AbstractDoubleRequest> {
+    AbstractPrimitiveRequest<Double, AbstractDoubleRequest> {

   public AbstractDoubleRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(Double.valueOf(responseText),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractEnumRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractEnumRequest.java Wed Aug 18 08:38:13 2010 
@@ -32,7 +32,7 @@
  * @param <E> an enum type
  */
 public abstract class AbstractEnumRequest<E extends Enum<E>> extends
-    AbstractRequest<Integer, AbstractEnumRequest<E>> {
+    AbstractPrimitiveRequest<Integer, AbstractEnumRequest<E>> {

   private E[] enumValues;

@@ -41,7 +41,7 @@
     this.enumValues = enumValues;
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     int ordinal = Integer.valueOf(responseText);
     for (E e : enumValues) {
       if (ordinal == e.ordinal()) {
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractFloatRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractFloatRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Float.
  */
 public abstract class AbstractFloatRequest extends
-    AbstractRequest<Float, AbstractFloatRequest> {
+    AbstractPrimitiveRequest<Float, AbstractFloatRequest> {

   public AbstractFloatRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(Float.valueOf(responseText),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java Fri Jul 30 11:32:15 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Integer.
  */
 public abstract class AbstractIntegerRequest extends
-    AbstractRequest<Integer, AbstractIntegerRequest> {
+    AbstractPrimitiveRequest<Integer, AbstractIntegerRequest> {

   public AbstractIntegerRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(Integer.valueOf(responseText),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java Fri Aug 13 14:38:39 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java Wed Aug 18 08:38:13 2010 
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.requestfactory.client.impl;

+import com.google.gwt.core.client.JavaScriptObject;
 import com.google.gwt.core.client.JsArray;
 import com.google.gwt.requestfactory.shared.RecordListRequest;
 import com.google.gwt.valuestore.shared.Record;
@@ -49,10 +50,9 @@
     this.schema = schema;
   }

-  public void handleResponseText(String text) {
-    RecordJsoImpl.JsonResults results = RecordJsoImpl.fromResults(text);
-
-    JsArray<RecordJsoImpl> valueJsos = results.getListResult();
+  public void handleJsonResult(JavaScriptObject jsoResult) {
+
+    JsArray<RecordJsoImpl> valueJsos = jsoResult.cast();
     List<T> valueList = new ArrayList<T>(valueJsos.length());
     for (int i = 0; i < valueJsos.length(); i++) {
       RecordJsoImpl jso = valueJsos.get(i);
@@ -61,7 +61,6 @@
     }

     requestFactory.getValueStore().setRecords(valueJsos, requestFactory);
-    processRelated(results.getRelated());

     receiver.onSuccess(valueList, Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java Fri Aug 13 14:38:39 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java Wed Aug 18 08:38:13 2010 
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.requestfactory.client.impl;

+import com.google.gwt.core.client.JavaScriptObject;
 import com.google.gwt.requestfactory.shared.RecordRequest;
 import com.google.gwt.valuestore.shared.Record;
 import com.google.gwt.valuestore.shared.SyncResult;
@@ -43,14 +44,12 @@
     this.schema = schema;
   }

-  public void handleResponseText(String text) {
-    RecordJsoImpl.JsonResults results = RecordJsoImpl.fromResults(text);
-
-    RecordJsoImpl jso = results.getResult();
+  public void handleJsonResult(JavaScriptObject jsoResult) {
+
+    RecordJsoImpl jso = jsoResult.cast();
     jso.setSchema(schema);

     requestFactory.getValueStore().setRecord(jso, requestFactory);
-    processRelated(results.getRelated());
receiver.onSuccess(schema.create(jso), Collections.<SyncResult>emptySet()); 
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java Fri Jul 30 11:32:15 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Long.
  */
 public abstract class AbstractLongRequest extends
-    AbstractRequest<Long, AbstractLongRequest> {
+    AbstractPrimitiveRequest<Long, AbstractLongRequest> {

   public AbstractLongRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(Long.valueOf(responseText),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java Wed Aug 18 03:40:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java Wed Aug 18 08:38:13 2010 
@@ -53,6 +53,10 @@
         requestFactory);
   }

+  public native String asString(JavaScriptObject jso) /*-{
+    return String(jso);
+  }-*/;
+
   public void clearUsed() {
     deltaValueStore.clearUsed();
   }
@@ -90,6 +94,12 @@
     return Collections.unmodifiableSet(propertyRefs);
   }

+  public void handleResponseText(String responseText) {
+ RecordJsoImpl.JsonResults results = RecordJsoImpl.fromResults(responseText); 
+    processRelated(results.getRelated());
+    handleJsonResult(results.getJavascriptResult());
+  }
+
   public boolean isChanged() {
     return deltaValueStore.isChanged();
   }
@@ -117,6 +127,8 @@
    */
   protected abstract R getThis();

+  protected abstract void handleJsonResult(JavaScriptObject result);
+
   protected native void processRelated(JavaScriptObject related) /*-{
     for(var recordKey in related) {
       var schemaAndId = recordKey.split(/-/, 2);
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractShortRequest.java Fri Jul 30 17:29:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractShortRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Short.
  */
 public abstract class AbstractShortRequest extends
-    AbstractRequest<Short, AbstractShortRequest> {
+    AbstractPrimitiveRequest<Short, AbstractShortRequest> {

   public AbstractShortRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     receiver.onSuccess(Short.valueOf(responseText),
         Collections.<SyncResult> emptySet());
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractVoidRequest.java Wed Aug 11 06:10:03 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractVoidRequest.java Wed Aug 18 08:38:13 2010 
@@ -30,13 +30,13 @@
  * RequestFactory.RequestObject} for requests that return Void.
  */
 public abstract class AbstractVoidRequest extends
-    AbstractRequest<Void, AbstractVoidRequest> {
+    AbstractPrimitiveRequest<Void, AbstractVoidRequest> {

   public AbstractVoidRequest(RequestFactoryJsonImpl requestFactory) {
     super(requestFactory);
   }

-  public void handleResponseText(String responseText) {
+  public void handlePrimitiveResult(String responseText) {
     Set<SyncResult> syncResults = deltaValueStore.commit(responseText);
     receiver.onSuccess(null, syncResults);
   }
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java Tue Aug 17 13:12:08 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java Wed Aug 18 08:38:13 2010 
@@ -43,17 +43,21 @@
     protected JsonResults() {
     }

-    public final native JsArray<RecordJsoImpl> getListResult() /*-{
+    public final native JavaScriptObject getJavascriptResult() /*-{
       return this.result;
     }-*/;

-    public final native JavaScriptObject getRelated() /*-{
-      return this.related;
+    public final native JsArray<RecordJsoImpl> getListResult() /*-{
+      return this.result;
     }-*/;

-    public final native RecordJsoImpl getResult() /*-{
+    public final native RecordJsoImpl getRecordResult() /*-{
       return this.result;
     }-*/;
+
+    public final native JavaScriptObject getRelated() /*-{
+      return this.related;
+    }-*/;
   }
public static native JsArray<RecordJsoImpl> arrayFromJson(String json) /*-{ 
@@ -311,7 +315,6 @@
     throw new UnsupportedOperationException(
         "Can't yet set properties of type " + value.getClass().getName());
   }
-

   // TODO: HACK! Need to look up token to schema for relatins
public final native void setRequestFactory(RequestFactoryJsonImpl requestFactory) /*-{ 
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java Mon Aug 16 20:22:31 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java Wed Aug 18 08:38:13 2010 
@@ -96,7 +96,7 @@
         wireLogger.finest("Response received");
         if (200 == response.getStatusCode()) {
           String text = response.getText();
-          requestObject.handleResponseText(text);
+          ((AbstractRequest) requestObject).handleResponseText(text);
         } else if (Response.SC_UNAUTHORIZED == response.getStatusCode()) {
           wireLogger.finest("Need to log in");
         } else if (response.getStatusCode() > 0) {
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java Wed Aug 18 03:40:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java Wed Aug 18 08:38:13 2010 
@@ -53,6 +53,8 @@
  */
 public class JsonRequestProcessor implements RequestProcessor<String> {

+  public static final String RELATED = "related";
+
   // TODO should we consume String, InputStream, or JSONObject?
   private class DvsData {
     private final JSONObject jsonObject;
@@ -673,23 +675,23 @@
               domainMethod.getReturnType()));
     }

+    JSONObject envelop = new JSONObject();
     if (result instanceof List<?>) {
-      JSONObject envelop = new JSONObject();
-      envelop.put("result", toJsonArray(operation, result));
-      envelop.put("related", encodeRelatedObjectsToJson());
+ envelop.put(RequestData.RESULT_TOKEN, toJsonArray(operation, result)); 
       envelop.put("sideEffects", sideEffects);
       return envelop;
-    } else if (result instanceof Number
- && !(result instanceof BigDecimal || result instanceof BigInteger)) { 
-      return result;
+    } else if (result instanceof Number || result instanceof Enum
+        || result instanceof String || result instanceof Date
+        || result instanceof Character || result instanceof Boolean) {
+      envelop.put(RequestData.RESULT_TOKEN, result);
     } else {
-      JSONObject envelop = new JSONObject();
       JSONObject jsonObject = toJsonObject(operation, result);
-      envelop.put("result", jsonObject);
-      envelop.put("related", encodeRelatedObjectsToJson());
+      envelop.put(RequestData.RESULT_TOKEN, jsonObject);
       envelop.put("sideEffects", sideEffects);
       return envelop;
     }
+    envelop.put(RequestData.RELATED_TOKEN, encodeRelatedObjectsToJson());
+    return envelop;
   }

   public void setOperationRegistry(OperationRegistry operationRegistry) {
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/shared/RequestData.java Tue Aug 17 09:57:01 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/shared/RequestData.java Wed Aug 18 08:38:13 2010 
@@ -38,6 +38,10 @@
   public static final String PARAM_TOKEN = "param";
   public static final String PROPERTY_REF_TOKEN = "propertyRefs";

+  public static final String RESULT_TOKEN = "result";
+
+  public static final String RELATED_TOKEN = "related";
+
   // TODO: non-final is a hack for now.
   private String operation;
   private final Object[] parameters;
=======================================
--- /trunk/user/src/com/google/gwt/requestfactory/shared/RequestObject.java Wed Aug 18 03:40:09 2010 +++ /trunk/user/src/com/google/gwt/requestfactory/shared/RequestObject.java Wed Aug 18 08:38:13 2010 
@@ -40,8 +40,6 @@

   RequestData getRequestData();

-  void handleResponseText(String responseText);
-
   /**
    * Return true if there are outstanding changes that have not been
* communicated to the server yet. Note that it is illegal to call this method 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to