http://gwt-code-reviews.appspot.com/767802/diff/1/3
File
user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java
(right):

http://gwt-code-reviews.appspot.com/767802/diff/1/3#newcode93
user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java:93:
eval("xyz=" + json);
Should this method also set RF and ValueStore? Please look at other
places to create RecordJsoImpl.

http://gwt-code-reviews.appspot.com/767802/diff/1/4
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):

http://gwt-code-reviews.appspot.com/767802/diff/1/4#newcode291
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:291:
DvsData dvsData = dvsDataMap.get(entityKey);
Please double-check that the two entityKey mechanisms use the same
encoding.

http://gwt-code-reviews.appspot.com/767802/diff/1/4#newcode697
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:697:
}
After you merge to head, you will see that all if-branches have:

envelop.put(RequestData...., sideEffects);

Please move that statement to after the if-branches.

http://gwt-code-reviews.appspot.com/767802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to