LGTM On Fri, Aug 20, 2010 at 1:30 AM, <[email protected]> wrote:
> Reviewers: amitmanjhi, > > Description: > Restores our new friend ValueListBox, and muzzles a couple of his > unit tests which seem to fail on FireFox. The widget works > well manually, and M3 needs it. > > Review by: [email protected] > > Please review this at http://gwt-code-reviews.appspot.com/788801/show > > Affected files: > M bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMobile.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeDetailsView.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditView.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditView.ui.xml > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListView.java > A > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeRenderer.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportDetailsView.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditView.java > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditView.ui.xml > M > bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListView.java > M user/src/com/google/gwt/app/client/EditorSupport.java > D user/src/com/google/gwt/app/client/ProxyBox.java > D user/src/com/google/gwt/app/client/ProxyIdRenderer.java > D user/src/com/google/gwt/app/client/ProxyParser.java > D user/src/com/google/gwt/app/client/ProxyRenderer.java > D user/src/com/google/gwt/app/client/ReadonlyProxyBox.java > M user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java > M user/src/com/google/gwt/app/place/AbstractRecordListActivity.java > M user/src/com/google/gwt/app/place/AbstractRecordListView.java > M user/src/com/google/gwt/app/place/PropertyColumn.java > M user/src/com/google/gwt/app/place/PropertyView.java > A user/src/com/google/gwt/app/place/ProxyRenderer.java > M user/src/com/google/gwt/app/rebind/EditorSupportGenerator.java > M user/src/com/google/gwt/user/client/ui/HasConstrainedValue.java > A user/src/com/google/gwt/user/client/ui/ValueListBox.java > M user/src/com/google/gwt/user/client/ui/ValuePicker.java > M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java > M user/test/com/google/gwt/user/UISuite.java > M user/test/com/google/gwt/user/client/ui/ValueBoxBaseTest.java > A user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
