This looks really good. I have one question about the way the module
name is passed into the bootstrapping code, however.


http://gwt-code-reviews.appspot.com/784801/diff/1/5
File dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js
(right):

http://gwt-code-reviews.appspot.com/784801/diff/1/5#newcode123
dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js:123:
function installCode(code, isHosted) {
Instead of "isHosted", the name "isUrl" would make more sense from the
perspective of this function. There might well be reason to use this in
the future with a URL in web mode.

http://gwt-code-reviews.appspot.com/784801/diff/1/5#newcode153
dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js:153:
script2.text = "doHosted('__MODULE_NAME__');";
I believe this part could be simplified. Also, I'm not completely
certain that the first script tag will finish evaluating before the
second one.

Wouldn't the basic strategy from the iframe linker work? That is,
instead of installing "hosted.js", install "hosted.js?__MODULE_NAME__".
The code in hosted.js can then figure out its own URL and then pick out
the part after the "?" .

To find its own URL, the code in hosted.js could scan for script tags
using document.getElementsByTagName().

http://gwt-code-reviews.appspot.com/784801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to