http://gwt-code-reviews.appspot.com/771801/diff/28002/6006 File user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml.java (right):
http://gwt-code-reviews.appspot.com/771801/diff/28002/6006#newcode32 user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml.java:32: throw new NullPointerException("html is null"); Maybe add a note that's it's "safe" to have an exception message (and maybe make it even more detailed and meaningful) because it's expected to go away at compile time (I expect the GWT compiler to be smart enough to prune the exception code-path): having a null argument is probably a bug in the code generator. http://gwt-code-reviews.appspot.com/771801/diff/28002/6009 File user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java (right): http://gwt-code-reviews.appspot.com/771801/diff/28002/6009#newcode41 user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java:41: throw new NullPointerException("html is null"); See remark in OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml about the exception message being pruned or not. Given that the class is package-private and I haven't found calls where a 'null' could be passed, maybe give a more detailed message (if the GWT compiler is proven to be smart enough to prune it), or just an "assert html != null" (if the compiler is not smart enough) http://gwt-code-reviews.appspot.com/771801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
