Reviewers: rjrjr,

Description:
Public:  Modify checkstyle config to allow formating of Fluent style
builders
like

MyClass.builder()
.setFoo()
.setBar()
.build();

Specifically alows a DOT to have leading white space if it is the first
character on a line.


Please review this at http://gwt-code-reviews.appspot.com/812801/show

Affected files:
  M eclipse/settings/code-style/gwt-checkstyle-tests.xml
  M eclipse/settings/code-style/gwt-checkstyle.xml


Index: eclipse/settings/code-style/gwt-checkstyle-tests.xml
===================================================================
--- eclipse/settings/code-style/gwt-checkstyle-tests.xml        (revision 8665)
+++ eclipse/settings/code-style/gwt-checkstyle-tests.xml        (working copy)
@@ -212,7 +212,12 @@
         <module name="MethodParamPad"/>
         <module name="NoWhitespaceBefore">
             <property name="severity" value="error"/>
-            <property name="tokens" value="SEMI,DOT,POST_DEC,POST_INC"/>
+            <property name="tokens" value="SEMI,POST_DEC,POST_INC"/>
+        </module>
+        <module name="NoWhitespaceBefore">
+            <property name="severity" value="error"/>
+            <property name="allowLineBreaks" value="true"/>
+            <property name="tokens" value="DOT"/>
         </module>
         <module name="RedundantModifier"/>
         <module name="EqualsHashCode"/>
Index: eclipse/settings/code-style/gwt-checkstyle.xml
===================================================================
--- eclipse/settings/code-style/gwt-checkstyle.xml      (revision 8665)
+++ eclipse/settings/code-style/gwt-checkstyle.xml      (working copy)
@@ -193,7 +193,12 @@
         <module name="MethodParamPad"/>
         <module name="NoWhitespaceBefore">
             <property name="severity" value="error"/>
-            <property name="tokens" value="SEMI,DOT,POST_DEC,POST_INC"/>
+            <property name="tokens" value="SEMI,POST_DEC,POST_INC"/>
+        </module>
+        <module name="NoWhitespaceBefore">
+            <property name="severity" value="error"/>
+            <property name="allowLineBreaks" value="true"/>
+            <property name="tokens" value="DOT"/>
         </module>
         <module name="RedundantModifier"/>
         <module name="EqualsHashCode"/>


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to