http://gwt-code-reviews.appspot.com/826802/diff/3001/4001 File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001#newcode88 dev/core/src/com/google/gwt/core/ext/GeneratorContext.java:88: * com / google / gwt / core / client / Foo.properties</code> would be exposed On 2010/09/02 13:44:49, scottb wrote:
Formatter hates you.
i hate it. i have followed the README exactly. this is either another formatter bug or this file wasn't formatter properly before. http://gwt-code-reviews.appspot.com/826802/diff/3001/4002 File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/826802/diff/3001/4002#newcode502 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:502: return 0; On 2010/09/02 13:44:49, scottb wrote:
Thought you'd already committed this. :)
Nope. This and a couple other changes were pulled in from the old approach. http://gwt-code-reviews.appspot.com/826802/diff/3001/4004 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/826802/diff/3001/4004#newcode251 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:251: private final Map<String, Object> storage = new HashMap<String, Object>(); On 2010/09/02 13:44:49, scottb wrote:
As far as I can tell, lifetime of this map should be exactly the same
as the
lifetime of "generators", right?
More concretely, it looks like it's tied to the ModuleSpace. http://gwt-code-reviews.appspot.com/826802/diff/3001/4005 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (left): http://gwt-code-reviews.appspot.com/826802/diff/3001/4005#oldcode486 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:486: Memory.maybeDumpMemory("GoldenCudsBuilt"); On 2010/09/02 13:44:49, scottb wrote:
You've verified that the i18n cached state gets cleared here?
There are two components that were getting cleared via this hack. The ResourceFactory is addressed in this patch. The LocaleUtils I also address, but you may note that there is now now clearing of the GwtLocaleFactoryImpl. jat says that the GwtLocaleFactoryImpl was needlessly being cleared and recreated as it does not change between loads and is safe to share. http://gwt-code-reviews.appspot.com/826802/diff/3001/4009 File user/src/com/google/gwt/i18n/rebind/AnnotationsResource.java (right): http://gwt-code-reviews.appspot.com/826802/diff/3001/4009#newcode413 user/src/com/google/gwt/i18n/rebind/AnnotationsResource.java:413: throws AnnotationsError { On 2010/09/02 13:44:49, scottb wrote:
No real changes in this file.
i had some changes earlier but nuked them. formatter hates me. http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
