Thanks for the review! I just tested the late loading with ie 6, 7 and 8, as well as with some random script and meta tags, and it looks good, so I'm submitting. The whole linker will also get more extensive testing (and documentation) after the upcoming big cleanup patch.
For the XHTML changes, using this linker should take care of the doc.write elimination in that patch, but that patch also changes our DOM impl classes to output tags in lowercase rather than uppercase. Once this patch is submitted, I'll reply on that review thread letting that guy know about the linker, but I'm not sure what to tell him regarding the case changes. - Unnur On Fri, Sep 3, 2010 at 11:16 AM, <[email protected]> wrote: > Assuming everything works as expected, everything here looks good to me > (not bad for someone who claims to "not know Javascript" :) > > I'm stuck at home right now, so I don't have the facilities here to test > out IE, which is where any problems would likely crop up. In particular, > I'd make sure it works on IE6 and 7, and in the presence/absence of > "normal" script/meta tags (the stuff that might trip up > computeScriptBase(). > > Also, I assume it's intended that this *not* support script/style > injection from the .gwt.xml (fine with me -- those features have been > 1000x more trouble than they're worth). But we want to make sure we > document this fact somewhere. > > Finally, it looks like a lot of the work you've done here is equivalent > to the XHTML changes in http://codereview.appspot.com/1873052. While I > personally don't care much about XHTML, if it is the case that this just > happens to support it (because of the elimination of document.write()), > that would be nice to know. > > IOW, LGTM. > > http://gwt-code-reviews.appspot.com/807801/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
